You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "cryptoe (via GitHub)" <gi...@apache.org> on 2023/03/13 12:27:49 UTC
[GitHub] [druid] cryptoe opened a new pull request, #13928: Undocumenting certain context parameter in MSQ.
cryptoe opened a new pull request, #13928:
URL: https://github.com/apache/druid/pull/13928
It's not optimum to have so many tuning parameters in the docs. Features like`intermediateSuperSorterStorageMaxLocalBytes`,`maxInputBytesPerWorker`,`composedIntermediateSuperSorterStorageEnabled`, `clusterStatisticsMergeMode` are more developer focused and should not be set by external users until they face corner cases.
I think we should remove them until we have a good enough `auto` mode to free up our docs.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
#### Release note
Removing MSQ context params `intermediateSuperSorterStorageMaxLocalBytes`,`maxInputBytesPerWorker`, `composedIntermediateSuperSorterStorageEnabled`, `clusterStatisticsMergeMode` from docs since they should not be set by external users.
This PR has:
- [x] been self-reviewed.
- [x] a release note entry in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on pull request #13928: Undocumenting certain context parameter in MSQ.
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on PR #13928:
URL: https://github.com/apache/druid/pull/13928#issuecomment-1469444648
> Can we move this information into a Javadoc comment in the config class for these items? Then, at least developers will have the information and it won't be lost.
I like that proposal better. Just added some comments in `MultiStageQueryContext` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe merged pull request #13928: Undocumenting certain context parameter in MSQ.
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #13928:
URL: https://github.com/apache/druid/pull/13928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org