You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/02 18:14:59 UTC

[GitHub] [netbeans] BradWalker opened a new pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

BradWalker opened a new pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838
 
 
   There are a lot of places where we get raw type warnings..
   
      [repeat] /home/bwalker/src/netbeans/platform/core.multiview/src/org/netbeans/core/multiview/MultiViewPeer.java:1070: warning: [rawtypes] found raw type: List
      [repeat]         private List listeners = new ArrayList();
      [repeat]                 ^
      [repeat]   missing type arguments for generic class List<E>
      [repeat]   where E is a type-variable:
      [repeat]     E extends Object declared in interface List
   
   Clean up a bunch of these warnings..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362977824
 
 

 ##########
 File path: java/beans/src/org/netbeans/modules/beans/PropertyPatternPanel.java
 ##########
 @@ -519,7 +519,7 @@ public void actionPerformed( java.awt.event.ActionEvent e ) {
         if (TYPES == null) {
             String typeList = NbBundle.getMessage(PropertyPatternPanel.class, "IdxPropertyPatternPanel_Types"); // NOI18N
             StringTokenizer st = new StringTokenizer(typeList, "|"); // NOI18N
-            List l = new LinkedList();
+            List<String> l = new LinkedList();
 
 Review comment:
   Ugg.. Mismerge on my part.. Give me a second to fix.. Sorry about that..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lalo-mx commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
lalo-mx commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362976729
 
 

 ##########
 File path: java/beans/src/org/netbeans/modules/beans/PropertyPatternPanel.java
 ##########
 @@ -519,7 +519,7 @@ public void actionPerformed( java.awt.event.ActionEvent e ) {
         if (TYPES == null) {
             String typeList = NbBundle.getMessage(PropertyPatternPanel.class, "IdxPropertyPatternPanel_Types"); // NOI18N
             StringTokenizer st = new StringTokenizer(typeList, "|"); // NOI18N
-            List l = new LinkedList();
+            List<String> l = new LinkedList();
 
 Review comment:
   The list still accepts any objects. Is that wanted?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362950853
 
 

 ##########
 File path: java/beans/src/org/netbeans/modules/beans/PropertyPatternPanel.java
 ##########
 @@ -519,7 +519,7 @@ public void actionPerformed( java.awt.event.ActionEvent e ) {
         if (TYPES == null) {
             String typeList = NbBundle.getMessage(PropertyPatternPanel.class, "IdxPropertyPatternPanel_Types"); // NOI18N
             StringTokenizer st = new StringTokenizer(typeList, "|"); // NOI18N
-            List l = new LinkedList();
+            List<String> l = new LinkedList();
 
 Review comment:
   The instanziation is missing a diamond operator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on issue #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#issuecomment-570796043
 
 
   Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362951036
 
 

 ##########
 File path: ide/xml.multiview/src/org/netbeans/modules/xml/multiview/ui/SectionInnerPanel.java
 ##########
 @@ -49,7 +49,7 @@
     private static final RequestProcessor RP = new RequestProcessor(SectionInnerPanel.class);
 
     private SectionView sectionView;
-    private java.util.List refreshableList = new LinkedList();
+    private java.util.List<Refreshable> refreshableList = new LinkedList();
 
 Review comment:
   Missing Diamond.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362972976
 
 

 ##########
 File path: java/beans/src/org/netbeans/modules/beans/PropertyPatternPanel.java
 ##########
 @@ -519,7 +519,7 @@ public void actionPerformed( java.awt.event.ActionEvent e ) {
         if (TYPES == null) {
             String typeList = NbBundle.getMessage(PropertyPatternPanel.class, "IdxPropertyPatternPanel_Types"); // NOI18N
             StringTokenizer st = new StringTokenizer(typeList, "|"); // NOI18N
-            List l = new LinkedList();
+            List<String> l = new LinkedList();
 
 Review comment:
   good eyes.. fixed..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing merged pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362973027
 
 

 ##########
 File path: ide/xml.multiview/src/org/netbeans/modules/xml/multiview/ui/SectionInnerPanel.java
 ##########
 @@ -49,7 +49,7 @@
     private static final RequestProcessor RP = new RequestProcessor(SectionInnerPanel.class);
 
     private SectionView sectionView;
-    private java.util.List refreshableList = new LinkedList();
+    private java.util.List<Refreshable> refreshableList = new LinkedList();
 
 Review comment:
   ditto.. fixed..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1838: [NETBEANS-3659] - clean up List raw type warnings..
URL: https://github.com/apache/netbeans/pull/1838#discussion_r362985605
 
 

 ##########
 File path: java/beans/src/org/netbeans/modules/beans/PropertyPatternPanel.java
 ##########
 @@ -519,7 +519,7 @@ public void actionPerformed( java.awt.event.ActionEvent e ) {
         if (TYPES == null) {
             String typeList = NbBundle.getMessage(PropertyPatternPanel.class, "IdxPropertyPatternPanel_Types"); // NOI18N
             StringTokenizer st = new StringTokenizer(typeList, "|"); // NOI18N
-            List l = new LinkedList();
+            List<String> l = new LinkedList();
 
 Review comment:
   Should be fixed now..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists