You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:39:28 UTC

[GitHub] [arrow] yordan-pavlov commented on a change in pull request #7261: ARROW-8907: [Rust] Implement scalar comparison operations

yordan-pavlov commented on a change in pull request #7261:
URL: https://github.com/apache/arrow/pull/7261#discussion_r429953750



##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -66,6 +66,31 @@ macro_rules! compare_op {
     }};
 }
 
+macro_rules! compare_op_scalar {
+    ($left: expr, $right:expr, $op:expr) => {{
+        let null_bit_buffer =

Review comment:
       thanks @nevi-me , you are right, I have changed the scalar comparison code to clone the left null buffer




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org