[GitHub] vapiravfif commented on a change in pull request #4450: [AIRFLOW-3639] Fix request creation in Jenkins Operator

[GitBox <gi...@apache.org>]

vapiravfif commented on a change in pull request #4450: [AIRFLOW-3639] Fix request creation in Jenkins Operator
URL: https://github.com/apache/airflow/pull/4450#discussion_r254711851
 
 

 ##########
 File path: airflow/contrib/operators/jenkins_job_trigger_operator.py
 ##########
 @@ -35,27 +35,21 @@
     basestring = str  # For python3 compatibility
 
 
-# TODO Use jenkins_urlopen instead when it will be available
-# in the stable python-jenkins version (> 0.4.15)
 
 Review comment:
   Seems that jenkins_request was added in python-jenkins 1.0.0 
   That is also the version where they changed the authentication mechanism that causes original operator not to work. Authentication no more initialized on connection creation, there is an internal method for that now.
   1.0.0 - https://git.openstack.org/cgit/openstack/python-jenkins/tree/jenkins/__init__.py?h=1.0.0
   0.4.16 (single release between 0.4.15 and 1.0.0) - https://git.openstack.org/cgit/openstack/python-jenkins/tree/jenkins/__init__.py?h=0.4.16

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services