You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/06 20:53:59 UTC
Review Request 56343: Search in recent projects should also search in
path and search should be case insensitive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19882
https://issues.apache.org/jira/browse/AMBARI-19882
Repository: ambari
Description
-------
Search in recent projects should be case insensitive and should search in path also.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 33533db
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 802a8bc
Diff: https://reviews.apache.org/r/56343/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56343: Search in recent projects should also
search in path and search should be case insensitive
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/#review164463
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 6, 2017, 8:53 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56343/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 8:53 p.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19882
> https://issues.apache.org/jira/browse/AMBARI-19882
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Search in recent projects should be case insensitive and should search in path also.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 33533db
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 802a8bc
>
> Diff: https://reviews.apache.org/r/56343/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56343: Search in recent projects should also
search in path and search should be case insensitive
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/#review164476
-----------------------------------------------------------
contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js (line 30)
<https://reviews.apache.org/r/56343/#comment236233>
can we avoid using eval
- Nitiraj Rathore
On Feb. 6, 2017, 8:53 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56343/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 8:53 p.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19882
> https://issues.apache.org/jira/browse/AMBARI-19882
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Search in recent projects should be case insensitive and should search in path also.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 33533db
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 802a8bc
>
> Diff: https://reviews.apache.org/r/56343/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56343: Search in recent projects should also
search in path and search should be case insensitive
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/#review164499
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Feb. 7, 2017, 11:25 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56343/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19882
> https://issues.apache.org/jira/browse/AMBARI-19882
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Search in recent projects should be case insensitive and should search in path also.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 33533db
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 802a8bc
>
> Diff: https://reviews.apache.org/r/56343/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56343: Search in recent projects should also
search in path and search should be case insensitive
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 11:25 a.m.)
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19882
https://issues.apache.org/jira/browse/AMBARI-19882
Repository: ambari
Description
-------
Search in recent projects should be case insensitive and should search in path also.
Diffs (updated)
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 33533db
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs 802a8bc
Diff: https://reviews.apache.org/r/56343/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam