You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2026/10/22 10:28:21 UTC
[PR] JSPWIKI-919 VersioningFileProvider.pageExists() ignores the first ver… [jspwiki]
arturobernalg opened a new pull request, #539:
URL: https://github.com/apache/jspwiki/pull/539
JSPWIKI-919: https://issues.apache.org/jira/browse/JSPWIKI-919
A page dropped into the page directory has no OLD/ directory and so no history. VersioningFileProvider.getPageInfo() already treats such a page as version 1, but pageExists( name, 1 ) looked into OLD/ and returned false. With the page cache disabled, the page is fetched with version 1, and wiki:NoSuchPage (NoSuchPageTag) asks wikiPageExists( name, page.getVersion() ), so the page was shown as non existing.
pageExists( name, version ) now applies the same rule as getPageInfo().
Tests: VersioningFileProviderTest#testMigrationPageExistsFirstVersion fails without the change ("first version should exist") and passes with it. The jspwiki-main suite passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-919 VersioningFileProvider.pageExists() ignores the first ver… [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #539:
URL: https://github.com/apache/jspwiki/pull/539#issuecomment-6388483073
nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-919 VersioningFileProvider.pageExists() ignores the first ver… [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 merged PR #539:
URL: https://github.com/apache/jspwiki/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org