[GitHub] [incubator-netbeans] dukescript commented on issue #1154: Java Frontend Application wizard for Gradle

[GitBox <gi...@apache.org>]

dukescript commented on issue #1154: Java Frontend Application wizard for Gradle
URL: https://github.com/apache/incubator-netbeans/pull/1154#issuecomment-480671732
 
 
   Re. Review by @lkishalmi:
   
   > The Gradle files are need some love as well. It would be better to review them as source.
   
   Done. Most of the files is available as freemarker template.
   
   > As of actions, the reload rules can be just DEFAULT (removed from the properties) 
   
   Handled in 657726b
   
   > Do not add wrapper related files to the zip as those can be created by 
   > Gradle as a last step of installation.
   
   There are no `gradlew` files, as far as I can tell, but please take another look now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists