You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/26 20:41:47 UTC

[GitHub] [spark] gengliangwang opened a new pull request #24475: [SPARK-27580][SQL] Implement `doCanonicalize` in BatchScanExec for comparing query plan results

gengliangwang opened a new pull request #24475: [SPARK-27580][SQL] Implement `doCanonicalize` in BatchScanExec for comparing query plan results
URL: https://github.com/apache/spark/pull/24475
 
 
   ## What changes were proposed in this pull request?
   
   The method `QueryPlan.sameResult` is used for comparing logical plans in order to:
   1. cache data in CacheManager
   2. uncache data in CacheManager
   3. Reuse subqueries
   4. etc...
   
   Currently the method `sameReuslt` always return false for `BatchScanExec`. We should fix it by implementing `doCanonicalize` for the node.
   
   ## How was this patch tested?
   
   Unit test
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org