[GitHub] [tvm] leandron commented on a change in pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #8008:
URL: https://github.com/apache/tvm/pull/8008#discussion_r629402407



##########
File path: docker/install/ubuntu1804_install_llvm.sh
##########
@@ -36,10 +36,15 @@ echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
 echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
      >> /etc/apt/sources.list.d/llvm.list
 
+echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+     >> /etc/apt/sources.list.d/llvm.list
+echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+     >> /etc/apt/sources.list.d/llvm.list
+
 echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
      >> /etc/apt/sources.list.d/llvm.list
 echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
      >> /etc/apt/sources.list.d/llvm.list
 
 wget -q -O - http://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -
-apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev
+apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 llvm-12 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev clang-12 libclang-12-dev

Review comment:
       Given we usually maintain the last 3 version, I think we can remove version 9 in the same PR, keeping only 10, 11 and 12?
   
   Also cc @tqchen @jroesch for reviews




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org