You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/10 04:16:20 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
zhengruifeng opened a new pull request, #38594:
URL: https://github.com/apache/spark/pull/38594
### What changes were proposed in this pull request?
Make `Summary` a separate proto plan
### Why are the changes needed?
as per the discussion https://github.com/apache/spark/pull/38578#discussion_r1017875279 , those stats function cannot share fields
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
updated UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
URL: https://github.com/apache/spark/pull/38594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38594:
URL: https://github.com/apache/spark/pull/38594#issuecomment-1309898700
thank you @cloud-fan for reivews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38594:
URL: https://github.com/apache/spark/pull/38594#issuecomment-1309888458
cc @cloud-fan @HyukjinKwon @amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38594:
URL: https://github.com/apache/spark/pull/38594#issuecomment-1310693233
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38594: [SPARK-40852][CONNECT][PYTHON][FOLLOWUP] Make `Summary` a separate proto plan
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38594:
URL: https://github.com/apache/spark/pull/38594#issuecomment-1309893300
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org