[jira] [Commented] (ISIS-731) Bulk actions broken... the logic to re-execute the action fails

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925180#comment-13925180 ] 

ASF subversion and git services commented on ISIS-731:
------------------------------------------------------

Commit 990a0150b292408a7b9db6fa5874dce9d6224068 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=990a015 ]

ISIS-731: fix for bulk actions

Take a copy of the action model that generates the standalone collection.


> Bulk actions broken... the logic to re-execute the action fails
> ---------------------------------------------------------------
>
>                 Key: ISIS-731
>                 URL: https://issues.apache.org/jira/browse/ISIS-731
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.4.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: viewer-wicket-1.4.1
>
>
> ISIS-718 seems to be the culprit; we clear the action model's arguments for an action panel because it may get reused, however this same action model is cached by the collection model of an action that returns a standalone collection, and re-executed after the bulk action is performed.  This results in a NPE, because those arguments were cleared.
> The fix (a fix) is for the collection panel to clone the action model.
> This issue discovered during voting for 1.4.0; rather than pull that vote, suggest we fix in a patch release 1.4.1



--
This message was sent by Atlassian JIRA
(v6.2#6252)