You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2023/03/02 23:56:33 UTC
[GitHub] [bookkeeper] merlimat opened a new pull request, #3835: Pass BookieRequestHandler instead of Channel to the request processors
merlimat opened a new pull request, #3835:
URL: https://github.com/apache/bookkeeper/pull/3835
### Motivation
This is just a preparatory refactoring change. The final goal is to streamline the send-response path from Journal to the client connections.
We're now passing the Netty Channel object as context for the requests, though that prevents us from adding more state and logic when tracking back to the original connection.
Instead, we can pass `BookieRequestHandler` where we can potentially add new fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3835: Pass BookieRequestHandler instead of Channel to the request processors
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3835:
URL: https://github.com/apache/bookkeeper/pull/3835#issuecomment-1454815737
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3835](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35c277f) into [master](https://codecov.io/gh/apache/bookkeeper/commit/b4112dfdbf29c16da89d914d44faaa8c821723a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4112df) will **decrease** coverage by `47.20%`.
> The diff coverage is `50.63%`.
```diff
@@ Coverage Diff @@
## master #3835 +/- ##
=============================================
- Coverage 68.21% 21.01% -47.20%
+ Complexity 6761 2018 -4743
=============================================
Files 473 473
Lines 40950 40967 +17
Branches 5240 5243 +3
=============================================
- Hits 27935 8611 -19324
- Misses 10762 31073 +20311
+ Partials 2253 1283 -970
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `?` | |
| client | `?` | |
| remaining | `?` | |
| replication | `?` | |
| tls | `21.01% <50.63%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/bookkeeper/proto/ForceLedgerProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vRm9yY2VMZWRnZXJQcm9jZXNzb3JWMy5qYXZh) | `0.00% <0.00%> (-49.10%)` | :arrow_down: |
| [...che/bookkeeper/proto/GetBookieInfoProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vR2V0Qm9va2llSW5mb1Byb2Nlc3NvclYzLmphdmE=) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [...per/proto/GetListOfEntriesOfLedgerProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vR2V0TGlzdE9mRW50cmllc09mTGVkZ2VyUHJvY2Vzc29yVjMuamF2YQ==) | `0.00% <0.00%> (-76.75%)` | :arrow_down: |
| [...bookkeeper/proto/LongPollReadEntryProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vTG9uZ1BvbGxSZWFkRW50cnlQcm9jZXNzb3JWMy5qYXZh) | `0.00% <0.00%> (-56.39%)` | :arrow_down: |
| [...rg/apache/bookkeeper/proto/ReadLacProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUmVhZExhY1Byb2Nlc3NvclYzLmphdmE=) | `0.00% <0.00%> (-73.34%)` | :arrow_down: |
| [...g/apache/bookkeeper/proto/WriteLacProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vV3JpdGVMYWNQcm9jZXNzb3JWMy5qYXZh) | `0.00% <0.00%> (-40.79%)` | :arrow_down: |
| [...rg/apache/bookkeeper/proto/ReadEntryProcessor.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUmVhZEVudHJ5UHJvY2Vzc29yLmphdmE=) | `29.12% <33.33%> (-21.86%)` | :arrow_down: |
| [...g/apache/bookkeeper/proto/PacketProcessorBase.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUGFja2V0UHJvY2Vzc29yQmFzZS5qYXZh) | `41.58% <45.45%> (-13.63%)` | :arrow_down: |
| [...pache/bookkeeper/proto/BookieRequestProcessor.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vQm9va2llUmVxdWVzdFByb2Nlc3Nvci5qYXZh) | `41.22% <51.51%> (-32.98%)` | :arrow_down: |
| [.../apache/bookkeeper/proto/ReadEntryProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUmVhZEVudHJ5UHJvY2Vzc29yVjMuamF2YQ==) | `31.72% <60.00%> (-32.86%)` | :arrow_down: |
| ... and [382 more](https://codecov.io/gh/apache/bookkeeper/pull/3835?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3835: Pass BookieRequestHandler instead of Channel to the request processors
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3835:
URL: https://github.com/apache/bookkeeper/pull/3835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org