You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/03 03:17:01 UTC
[GitHub] zheng-da commented on a change in pull request #13667: [MXNET-1253]
[WIP] Fix large array issue in topk operator
zheng-da commented on a change in pull request #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator
URL: https://github.com/apache/incubator-mxnet/pull/13667#discussion_r244906530
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -58,7 +58,6 @@ struct TopKParam : public dmlc::Parameter<TopKParam> {
int k;
int ret_typ;
bool is_ascend;
- int dtype;
Review comment:
agree. could you please revert the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services