You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/16 14:34:46 UTC

[GitHub] [arrow-rs] jiacai2050 opened a new issue, #3356: Is it possible for ArrowWriter to write key_value_metadata after write all records

jiacai2050 opened a new issue, #3356:
URL: https://github.com/apache/arrow-rs/issues/3356

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   The metadata of parquet is placed in the footer, In this design, metadata can be written after the data has been written, which allow for single pass writing.
   
   But in current implementation of ArrowWriter, we can only provide WriterProperties in `try_new`, for most fields of WriterProperties this is fine, but not the case for key_value_metadata.
   
   key_value_metadata is meant for users to save customized information, for example we can encode some stats in here.
   
   This usually means that we need to loop the original data to get stats information, this means we have to loop data twice:
   1. First to get the stats information
   2. Second to write to parquet
   
   If ArrowWriter could provide a way to set key_value_metadata  after write all records, then only one loop is need.
   
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   Add new method in ArrowWriter/SerializedFileWriter to let users set key_value_metadata.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] jiacai2050 commented on issue #3356: Is it possible for ArrowWriter to write key_value_metadata after write all records

Posted by GitBox <gi...@apache.org>.
jiacai2050 commented on issue #3356:
URL: https://github.com/apache/arrow-rs/issues/3356#issuecomment-1356678884

   Thanks, I will open a PR to address this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #3356: Is it possible for ArrowWriter to write key_value_metadata after write all records

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3356:
URL: https://github.com/apache/arrow-rs/issues/3356#issuecomment-1367307335

   `label_issue.py` automatically added labels {'parquet'} from #3367


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on issue #3356: Is it possible for ArrowWriter to write key_value_metadata after write all records

Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #3356:
URL: https://github.com/apache/arrow-rs/issues/3356#issuecomment-1356269107

   Allowing the user to add additional key value metadata beyond those in the WriterProperties, prior to closing the writer makes sense to me :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #3356: Is it possible for ArrowWriter to write key_value_metadata after write all records

Posted by GitBox <gi...@apache.org>.
tustvold closed issue #3356: Is it possible for ArrowWriter to write key_value_metadata after write all records
URL: https://github.com/apache/arrow-rs/issues/3356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org