You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/11/06 01:22:13 UTC
zeppelin git commit: [ZEPPELIN-3022] The "Default Interpreter" select
box on the "Create new note" modal dialog has no contents when it is opened
via the "Create new note" link on
${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html
Repository: zeppelin
Updated Branches:
refs/heads/master 764fef58c -> aa01d9e9a
[ZEPPELIN-3022] The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on ${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html
### What is this PR for?
The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on $
{ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html.
Fix $
{ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html so that NoteCreateCtrl.getInterpreterSettings() is invoked when the "Create new note" link is clicked.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3022
### How should this be tested?
* Tested manually
* Before: "Default Interpreter" select box has no options
* <img width="1204" alt="zeppelin-3022_before" src="https://user-images.githubusercontent.com/31149688/32265997-daaad0ba-bf28-11e7-92d0-b0d53db25d7f.png">
* After: "Default Interpreter" select box has options successfully
* <img width="1209" alt="zeppelin-3022_after" src="https://user-images.githubusercontent.com/31149688/32266019-fcf4a5e2-bf28-11e7-8be3-7b02ace2d613.png">
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Keiji Yoshida <kj...@gmail.com>
Closes #2640 from kjmrknsn/ZEPPELIN-3022 and squashes the following commits:
ef4031d [Keiji Yoshida] [ZEPPELIN-3022] The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on ${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/aa01d9e9
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/aa01d9e9
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/aa01d9e9
Branch: refs/heads/master
Commit: aa01d9e9af4b358fa00f82a0c5f2190ad7c3a02f
Parents: 764fef5
Author: Keiji Yoshida <kj...@gmail.com>
Authored: Wed Nov 1 15:02:18 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon Nov 6 10:22:10 2017 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/home/notebook.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/aa01d9e9/zeppelin-web/src/app/home/notebook.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/home/notebook.html b/zeppelin-web/src/app/home/notebook.html
index f276a22..a6f2416 100644
--- a/zeppelin-web/src/app/home/notebook.html
+++ b/zeppelin-web/src/app/home/notebook.html
@@ -23,7 +23,7 @@ limitations under the License.
</h4>
<h5><a href="" data-toggle="modal" data-target="#noteImportModal" style="text-decoration: none;">
<i style="font-size: 15px;" class="fa fa-upload"></i> Import note</a></h5>
- <h5><a href="" data-toggle="modal" data-target="#noteCreateModal" style="text-decoration: none;">
+ <h5 ng-controller="NoteCreateCtrl as noteCreateCtrl"><a href="" data-toggle="modal" data-target="#noteCreateModal" style="text-decoration: none;" ng-click="noteCreateCtrl.getInterpreterSettings();">
<i style="font-size: 15px;" class="icon-notebook"></i> Create new note</a></h5>
<ul id="notebook-names">
<li class="filter-names" ng-include="'components/note-name-filter/note-name-filter.html'"></li>