You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:45:02 UTC

[GitHub] [arrow] fsaintjacques edited a comment on pull request #7245: ARROW-8885: [R] Don't include everything everywhere

fsaintjacques edited a comment on pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#issuecomment-632825223


   @nealrichardson the next step is probably to break `arrowExport.{h,cpp}` into one per file cpp file, e.g.
   
   ```
   src/buffer.cpp
   src/buffer.h
   src/buffer_export.cpp
   ...
   ```
   
   This will make the export file much smaller and require less headers to read, on top of allowing this to be parallelized (as opposed to a single thread for the huge file as it is). I suspect we can shave probably another 33%, the final link will still be a bottleneck. I'm not familiar with rcpp and it's restrictions/requirements, @romainfrancois might say if this is never going to work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org