You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:52:42 UTC
[GitHub] [beam] kamilwu opened a new pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
kamilwu opened a new pull request #11956:
URL: https://github.com/apache/beam/pull/11956
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445451720
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
Review comment:
Sure, but I think we need to change wording to `runtimeMs` as well, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649635906
Run Dataflow Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646609445
Run Java AvroIO Performance Test HDFS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445543215
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
+ .put("numResults", "integer")
+ .build();
+ if (options.getExportSummaryToBigQuery()) {
savePerfsToBigQuery(
BigQueryResultsPublisher.create(options.getBigQueryDataset(), schema),
options,
actual,
start);
}
+
+ if (options.getExportSummaryToInfluxDB()) {
+ final long timestamp = start.getMillis() / 1000; // seconds
Review comment:
Yes you guys are right seconds is ok for the timestamps but ms are good for the benchmark results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644180283
cc: @tysonjh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644146071
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644063116
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445401135
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
+ .put("numResults", "integer")
+ .build();
+ if (options.getExportSummaryToBigQuery()) {
savePerfsToBigQuery(
BigQueryResultsPublisher.create(options.getBigQueryDataset(), schema),
options,
actual,
start);
}
+
+ if (options.getExportSummaryToInfluxDB()) {
+ final long timestamp = start.getMillis() / 1000; // seconds
Review comment:
We've thought that we don't really need milliseconds. Even seconds are probably more than enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649636593
Run JavaPortabilityApi PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649676979
Thanks @iemejia!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646031166
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646529951
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445554688
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -19,14 +19,16 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Objects.requireNonNull;
-import static org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils.isNoneBlank;
import java.io.IOException;
import java.util.Collection;
+import java.util.Map;
+import org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils;
Review comment:
ah..I would swear I changed it...thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445395098
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
Review comment:
Sure, I'll remove it from implementation but not here (we want to preserve compatibility with BQ), I'll change it in influx publisher, thanks for the info!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144324
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649600105
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mwalenia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
mwalenia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r441348786
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -40,34 +43,72 @@
private InfluxDBPublisher() {}
+ public static void publishNexmarkResults(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishNexmark(results, settings));
+ }
+
public static void publishWithSettings(
final Collection<NamedTestResult> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishCommon(results, settings));
+ }
+
+ private static void publishWithCheck(
+ final InfluxDBSettings settings, final PublishFunction publishFunction) {
requireNonNull(settings, "InfluxDB settings must not be null");
if (isNoneBlank(settings.measurement, settings.database)) {
try {
- publish(results, settings);
- } catch (final Exception exception) {
+ publishFunction.publish();
+ } catch (Exception exception) {
LOG.warn("Unable to publish metrics due to error: {}", exception.getMessage(), exception);
}
} else {
LOG.warn("Missing property -- measurement/database. Metrics won't be published.");
}
}
- private static void publish(
- final Collection<NamedTestResult> results, final InfluxDBSettings settings) throws Exception {
+ private static void publishNexmark(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings)
+ throws Exception {
- final HttpClientBuilder builder = HttpClientBuilder.create();
+ final HttpClientBuilder builder = provideHttpBuilder(settings);
+ final HttpPost postRequest = providePOSTRequest(settings);
+ final StringBuilder metricBuilder = new StringBuilder();
+ results.forEach(
+ map ->
+ metricBuilder
+ .append(map.get("measurement"))
Review comment:
I'm wondering if it would make sense to extract the appends of keys and values to a method, but I can't find a nice and clean way of doing it. @kamilwu do you have any thoughts about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646611882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641865155
Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144427
Run Dataflow Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646613924
Run Load Tests Java ParDo SparkStructuredStreaming Batch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r441364796
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -40,34 +43,72 @@
private InfluxDBPublisher() {}
+ public static void publishNexmarkResults(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishNexmark(results, settings));
+ }
+
public static void publishWithSettings(
final Collection<NamedTestResult> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishCommon(results, settings));
+ }
+
+ private static void publishWithCheck(
+ final InfluxDBSettings settings, final PublishFunction publishFunction) {
requireNonNull(settings, "InfluxDB settings must not be null");
if (isNoneBlank(settings.measurement, settings.database)) {
try {
- publish(results, settings);
- } catch (final Exception exception) {
+ publishFunction.publish();
+ } catch (Exception exception) {
LOG.warn("Unable to publish metrics due to error: {}", exception.getMessage(), exception);
}
} else {
LOG.warn("Missing property -- measurement/database. Metrics won't be published.");
}
}
- private static void publish(
- final Collection<NamedTestResult> results, final InfluxDBSettings settings) throws Exception {
+ private static void publishNexmark(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings)
+ throws Exception {
- final HttpClientBuilder builder = HttpClientBuilder.create();
+ final HttpClientBuilder builder = provideHttpBuilder(settings);
+ final HttpPost postRequest = providePOSTRequest(settings);
+ final StringBuilder metricBuilder = new StringBuilder();
+ results.forEach(
+ map ->
+ metricBuilder
+ .append(map.get("measurement"))
Review comment:
How about adding a method `getKV` that would return a String in this format:" <key>=<value>", e.g. "runner=DataflowRunner"? This would reduce the number of appends.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642081794
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642832685
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642835462
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r444759631
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
Review comment:
Do we use this one? it looks with runtimeMs + numResults this is not needed anymore or we can deduce it if someone cares.
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
Review comment:
Since the goal is to improve the existing use case can we make this an integer and use ms instead to make it more precise?
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkQueryName.java
##########
@@ -42,8 +42,8 @@
PROCESSING_TIME_WINDOWS(12), // Query "12"
// Other non-numbered queries
- BOUNDED_SIDE_INPUT_JOIN,
- SESSION_SIDE_INPUT_JOIN;
+ BOUNDED_SIDE_INPUT_JOIN(13),
Review comment:
:+1:
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -19,14 +19,19 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+import static org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils.isBlank;
Review comment:
Do not depend on repackaged commons-lang3 this will probably be removed in the future so better add the explicit commons-lang3 import and corresponding classes.
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -66,30 +125,43 @@ private static void publish(
builder.setDefaultCredentialsProvider(provider);
}
- final HttpPost postRequest = new HttpPost(settings.host + "/write?db=" + settings.database);
+ return builder;
+ }
- final StringBuilder metricBuilder = new StringBuilder();
- results.stream()
Review comment:
nit: The original code with the strings looks uglier but somehow is easier to understand in a single read (so easier to maintain), the new one requires a lot of methods and jumping back and forth in code for not much. Can we go back to the older approach
##########
File path: .test-infra/metrics/kubernetes/beam-influxdb.yaml
##########
@@ -24,6 +24,7 @@ metadata:
data:
init-script.iql: |
CREATE RETENTION POLICY "a_year" ON "beam_test_metrics" DURATION 52w REPLICATION 1 DEFAULT
+ CREATE RETENTION POLICY "forever" ON "beam_test_metrics" DURATION INF REPLICATION 1
Review comment:
<3
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
+ .put("numResults", "integer")
+ .build();
+ if (options.getExportSummaryToBigQuery()) {
savePerfsToBigQuery(
BigQueryResultsPublisher.create(options.getBigQueryDataset(), schema),
options,
actual,
start);
}
+
+ if (options.getExportSummaryToInfluxDB()) {
+ final long timestamp = start.getMillis() / 1000; // seconds
Review comment:
Oh I thought timestamps in Influxe were in ms well probably we don't need that level of precision for the start timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642116959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642072375
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445543215
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
+ .put("numResults", "integer")
+ .build();
+ if (options.getExportSummaryToBigQuery()) {
savePerfsToBigQuery(
BigQueryResultsPublisher.create(options.getBigQueryDataset(), schema),
options,
actual,
start);
}
+
+ if (options.getExportSummaryToInfluxDB()) {
+ final long timestamp = start.getMillis() / 1000; // seconds
Review comment:
Yes you guys are right seconds is ok for the execution timestamp and ms is good for the benchmark run time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641866913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r441368908
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -40,34 +43,72 @@
private InfluxDBPublisher() {}
+ public static void publishNexmarkResults(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishNexmark(results, settings));
+ }
+
public static void publishWithSettings(
final Collection<NamedTestResult> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishCommon(results, settings));
+ }
+
+ private static void publishWithCheck(
+ final InfluxDBSettings settings, final PublishFunction publishFunction) {
requireNonNull(settings, "InfluxDB settings must not be null");
if (isNoneBlank(settings.measurement, settings.database)) {
try {
- publish(results, settings);
- } catch (final Exception exception) {
+ publishFunction.publish();
+ } catch (Exception exception) {
LOG.warn("Unable to publish metrics due to error: {}", exception.getMessage(), exception);
}
} else {
LOG.warn("Missing property -- measurement/database. Metrics won't be published.");
}
}
- private static void publish(
- final Collection<NamedTestResult> results, final InfluxDBSettings settings) throws Exception {
+ private static void publishNexmark(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings)
+ throws Exception {
- final HttpClientBuilder builder = HttpClientBuilder.create();
+ final HttpClientBuilder builder = provideHttpBuilder(settings);
+ final HttpPost postRequest = providePOSTRequest(settings);
+ final StringBuilder metricBuilder = new StringBuilder();
+ results.forEach(
+ map ->
+ metricBuilder
+ .append(map.get("measurement"))
Review comment:
Yeah, makes sense, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642037822
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r441365016
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -40,34 +43,72 @@
private InfluxDBPublisher() {}
+ public static void publishNexmarkResults(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishNexmark(results, settings));
+ }
+
public static void publishWithSettings(
final Collection<NamedTestResult> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishCommon(results, settings));
+ }
+
+ private static void publishWithCheck(
+ final InfluxDBSettings settings, final PublishFunction publishFunction) {
requireNonNull(settings, "InfluxDB settings must not be null");
if (isNoneBlank(settings.measurement, settings.database)) {
try {
- publish(results, settings);
- } catch (final Exception exception) {
+ publishFunction.publish();
+ } catch (Exception exception) {
LOG.warn("Unable to publish metrics due to error: {}", exception.getMessage(), exception);
}
} else {
LOG.warn("Missing property -- measurement/database. Metrics won't be published.");
}
}
- private static void publish(
- final Collection<NamedTestResult> results, final InfluxDBSettings settings) throws Exception {
+ private static void publishNexmark(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings)
+ throws Exception {
- final HttpClientBuilder builder = HttpClientBuilder.create();
+ final HttpClientBuilder builder = provideHttpBuilder(settings);
+ final HttpPost postRequest = providePOSTRequest(settings);
+ final StringBuilder metricBuilder = new StringBuilder();
+ results.forEach(
+ map ->
+ metricBuilder
+ .append(map.get("measurement"))
Review comment:
@pawelpasterz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642116959
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649477157
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641927471
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445395098
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
Review comment:
Sure, I'll remove it from implementation but not here, I'll change it in influx publisher, thanks for the tip!
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
Review comment:
Sure, I'll remove it from implementation but not here, I'll change it in influx publisher, thanks for the info!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144102
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642025383
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641865155
Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642093374
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642181079
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642120033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641867173
Run Spark Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641927471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646526949
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445336567
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
+ .put("eventsPerSec", "float")
+ .put("numResults", "integer")
+ .build();
+ if (options.getExportSummaryToBigQuery()) {
savePerfsToBigQuery(
BigQueryResultsPublisher.create(options.getBigQueryDataset(), schema),
options,
actual,
start);
}
+
+ if (options.getExportSummaryToInfluxDB()) {
+ final long timestamp = start.getMillis() / 1000; // seconds
Review comment:
The default precision is nanoseconds. In case of nexmark results we changed it and use seconds instead
```
return new HttpPost(
settings.host + "/write?db=" + settings.database + "&" + retentionPolicy + "&precision=s");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644123390
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649480887
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642025383
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445546038
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -19,14 +19,16 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Objects.requireNonNull;
-import static org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils.isNoneBlank;
import java.io.IOException;
import java.util.Collection;
+import java.util.Map;
+import org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils;
Review comment:
argh this commons import escaped here too. Can you use the non repackaged version please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641864568
Run Java TextIO Performance Test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642824544
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu merged pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu merged pull request #11956:
URL: https://github.com/apache/beam/pull/11956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649605203
Run Beam Metrics deployment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644180183
R: @iemejia Could you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644134990
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649603723
Run Dataflow Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649481036
Run Java AvroIO Performance Test HDFS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649636524
Run JavaPortabilityApiJava11 PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644103035
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r441364796
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -40,34 +43,72 @@
private InfluxDBPublisher() {}
+ public static void publishNexmarkResults(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishNexmark(results, settings));
+ }
+
public static void publishWithSettings(
final Collection<NamedTestResult> results, final InfluxDBSettings settings) {
+ publishWithCheck(settings, () -> publishCommon(results, settings));
+ }
+
+ private static void publishWithCheck(
+ final InfluxDBSettings settings, final PublishFunction publishFunction) {
requireNonNull(settings, "InfluxDB settings must not be null");
if (isNoneBlank(settings.measurement, settings.database)) {
try {
- publish(results, settings);
- } catch (final Exception exception) {
+ publishFunction.publish();
+ } catch (Exception exception) {
LOG.warn("Unable to publish metrics due to error: {}", exception.getMessage(), exception);
}
} else {
LOG.warn("Missing property -- measurement/database. Metrics won't be published.");
}
}
- private static void publish(
- final Collection<NamedTestResult> results, final InfluxDBSettings settings) throws Exception {
+ private static void publishNexmark(
+ final Collection<Map<String, Object>> results, final InfluxDBSettings settings)
+ throws Exception {
- final HttpClientBuilder builder = HttpClientBuilder.create();
+ final HttpClientBuilder builder = provideHttpBuilder(settings);
+ final HttpPost postRequest = providePOSTRequest(settings);
+ final StringBuilder metricBuilder = new StringBuilder();
+ results.forEach(
+ map ->
+ metricBuilder
+ .append(map.get("measurement"))
Review comment:
How about adding a method `getKV` that would return a String in this format: "key=value", e.g. "runner=DataflowRunner"? This would reduce the number of appends.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644077825
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642119197
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644134990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445331560
##########
File path: sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##########
@@ -66,30 +125,43 @@ private static void publish(
builder.setDefaultCredentialsProvider(provider);
}
- final HttpPost postRequest = new HttpPost(settings.host + "/write?db=" + settings.database);
+ return builder;
+ }
- final StringBuilder metricBuilder = new StringBuilder();
- results.stream()
Review comment:
Hm...sure we can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641865785
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642060169
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642025600
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649631360
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642119592
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-646611882
Run Load Tests Java ParDo SparkStructuredStreaming Batch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641851529
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642181079
Run Direct Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445542488
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
Review comment:
Yes good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-649481211
Run Dataflow Runner Nexmark Tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-644222601
New results will be displayed in Grafana once this pull request is merged. The results of tests executed by phase triggering are written to different measurement (or table).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org