You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/25 16:35:23 UTC
[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1032: IGNITE-17485: Gradle build support
PakhomovAlexander commented on code in PR #1032:
URL: https://github.com/apache/ignite-3/pull/1032#discussion_r954924598
##########
build.gradle:
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+repositories {
+ mavenLocal()
+ maven {
+ url = uri('https://repository.apache.org/snapshots')
+ }
+
+ maven {
+ url = uri('https://repo.maven.apache.org/maven2/')
+ }
+}
+
+ext {
+ repos = [
+ 'apache-release' : "https://repo.maven.apache.org/maven2/",
+ 'apache-snapshot' : "https://repository.apache.org/snapshots"
+ ]
+}
+
+allprojects {
+ group 'org.apache.ignite'
+ version = "3.0.0-SNAPSHOT"
+
+ tasks.withType(Test) {
+ defaultCharacterEncoding = 'UTF-8'
+
+ jvmArgs += ["--add-opens=java.base/java.lang=ALL-UNNAMED",
+ "--add-opens=java.base/java.lang.invoke=ALL-UNNAMED",
+ "--add-opens=java.base/java.lang.reflect=ALL-UNNAMED",
+ "--add-opens=java.base/java.io=ALL-UNNAMED",
+ "--add-opens=java.base/java.nio=ALL-UNNAMED",
+ "--add-opens=java.base/java.math=ALL-UNNAMED",
+ "--add-opens=java.base/java.util=ALL-UNNAMED",
+ "--add-opens=java.base/jdk.internal.misc=ALL-UNNAMED",
+ "-Dio.netty.tryReflectionSetAccessible=true",
+ "-Djava.util.logging.config.file=${project.rootDir}/config/java.util.logging.properties"]
+ }
+
+ tasks.withType(Javadoc) {
+ options.tags = [ "apiNote" ]
+ }
+
+ tasks.withType(JavaCompile) {
+ options.encoding = 'UTF-8'
+ }
+}
+
+subprojects {
+ apply plugin: 'base'
+
+ repositories {
+ mavenLocal()
+ maven {
+ url = uri('https://repository.apache.org/snapshots')
+ mavenContent {
+ snapshotsOnly()
+ }
+ }
+
+ maven {
+ url = uri('https://repo.maven.apache.org/maven2/')
+ mavenContent {
+ releasesOnly()
+ }
+ }
+ }
+}
Review Comment:
Set up end of file pre-commit check in your IDE.
##########
examples/build.gradle:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
Review Comment:
```suggestion
apply from: "$rootDir/buildscripts/java-library.gradle"
```
##########
gradle/libs.versions.toml:
##########
@@ -0,0 +1,213 @@
+[versions]
+ivy="2.5.0"
+assertj="3.22.0"
+asmVer="9.0"
+compileTesting="0.19"
+fliptables="1.1.0"
+jackson="2.13.1"
+jakarta="2.0.0"
+jansiVer="1.18"
+netty="4.1.70.Final"
+javapoet="1.13.0"
+javax="1.3.2"
+jetbrains-annotations="20.1.0"
+jlineVer="3.21.0"
+jmh="1.35"
+junit5="5.8.1"
+jsr305="3.0.2"
+okhttpVer="4.9.1"
+gsonVer="2.8.9"
+gson-fire="1.8.5"
+threetenbp="1.5.2"
+micronautVer="3.5.3"
+micronaut-picocli-ver="4.1.0"
+micronaut-junit5-ver="3.4.0"
+mockito="4.3.1"
+picocliVer="4.6.2"
+slf4j="1.7.32"
+spoon="8.4.0-beta-18"
+swagger-legacy="1.6.4"
+swaggerVer="2.1.12"
+swaggerLegacyVer="1.6.4"
+typesafe="1.4.1"
+hamcrestVer="2.2"
+hamcrest-optional="2.0.0"
+hamcrest-path="1.0.1"
+scalecube="2.6.12"
+calcite="1.30.0"
+valueVer="2.8.8"
Review Comment:
Some variables have `Ver` postfix, some not. Could you unify all of them?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/raft/RocksDbClusterStateStorageManagerTest.java:
##########
@@ -1,6 +1,6 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
+ * contributor license agreements. See the NOTICE file distributed with
Review Comment:
```suggestion
* contributor license agreements. See the NOTICE file distributed with
```
##########
modules/raft/build.gradle:
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "$rootDir/buildscripts/java-integration-test.gradle"
+apply from: "$rootDir/buildscripts/java-test-fixtures.gradle"
+
+dependencies {
+ implementation project(':ignite-core')
+ implementation project(':ignite-raft-client')
+ implementation project(':ignite-network')
+ implementation libs.jetbrains.annotations
+ implementation libs.fastutil.core
+ implementation libs.disruptor
+ implementation libs.rocksdb.jni
+ implementation libs.dropwizard.metrics
+ implementation libs.jctools.core
+ annotationProcessor project(":ignite-network-annotation-processor")
+ annotationProcessor libs.jmh.annotation.processor
+
+ testAnnotationProcessor project(":ignite-network-annotation-processor")
+ testImplementation(testFixtures(project(':ignite-core')))
+ testImplementation(testFixtures(project(':ignite-network')))
+ testImplementation project(':ignite-configuration')
+ testImplementation project(':ignite-core')
+ testImplementation project(':ignite-network')
+ testImplementation libs.mockito.junit
+ testImplementation libs.mockito.core
+ testImplementation libs.netty.common
+ testImplementation libs.hamcrest.core
+ testImplementation libs.jmh.core
+ testImplementation libs.classgraph
+ testImplementation libs.slf4j.jdk14
+
+ testFixturesImplementation project(':ignite-core')
+ testFixturesImplementation project(':ignite-network')
+ testFixturesImplementation project(':ignite-raft-client')
+ testFixturesImplementation libs.mockito.core
+ testFixturesImplementation libs.junit5.api
+
+ integrationTestImplementation(testFixtures(project(':ignite-core')))
+ integrationTestImplementation(testFixtures(project(':ignite-network')))
+}
+
+//sourceSets {
+// integrationTest
+// test.java.srcDirs += ['src/integrationTest/java']
+//}
+
+//test {
+// maxHeapSize = "32g"
+//}
+
+description = 'ignite-raft'
+
+//tasks.register('testsJar', Jar) {
+// archiveClassifier = 'tests'
+// from(sourceSets.test.output)
+//}
+//
+//publishing.publications.maven.artifact(testsJar)
Review Comment:
commented code again
##########
modules/affinity/build.gradle:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
Review Comment:
could you remove `{}` from all places?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/raft/RocksDbClusterStateStorageManagerTest.java:
##########
@@ -17,9 +17,13 @@
package org.apache.ignite.internal.cluster.management.raft;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
+
/**
* Tests for {@link RaftStorageManager} based on {@link RocksDbClusterStateStorage}.
*/
+@DisabledOnOs(OS.WINDOWS)
Review Comment:
Any ticket to resolve this issue?
##########
modules/client/src/test/java/org/apache/ignite/client/ClientArchTest.java:
##########
@@ -72,7 +71,7 @@ public Set<Location> get(Class<?> testClass) {
}
}
- @ArchTest
+ //@ArchTest
Review Comment:
Any linked jira ticket or this is just a mistake?
##########
modules/cli/build.gradle:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.openapitools.generator.gradle.plugin.tasks.GenerateTask
+
+plugins {
+ alias(libs.plugins.openapiGenerator)
+ id 'idea'
+ id 'application'
+}
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "$rootDir/buildscripts/java-integration-test.gradle"
+
+description = 'ignite-cli'
+
+dependencies {
+ annotationProcessor libs.picocli.annotation.processor
+ annotationProcessor libs.micronaut.inject.annotation.processor
+ annotationProcessor libs.micronaut.validation.annotation.processor
+
+ implementation project(':ignite-cli-common')
+ implementation project(':ignite-core')
+ implementation project(':ignite-api')
+ implementation project(':ignite-client')
+
+ implementation libs.fliptables
+ implementation libs.jline.core
+ implementation libs.jline.console
+ implementation libs.micronaut.inject
+ implementation libs.micronaut.validation
+ implementation libs.micronaut.runtime
+ implementation libs.micronaut.picocli
+ implementation libs.jansi.core
+ implementation libs.picocli.shell.jline3
+ implementation libs.picocli.core
+ implementation libs.jackson.databind
+ implementation libs.apache.ivy
+ implementation libs.typesafe.config
+ implementation libs.slf4j.jdk14
+ implementation libs.gson.core
+ implementation libs.gson.fire
+ implementation libs.jsr305
+ implementation libs.okhttp.core
+ implementation libs.okhttp.logging
+ implementation libs.threetenbp
+ implementation libs.swagger.legacy.annotations
+
+ testAnnotationProcessor libs.picocli.annotation.processor
+ testAnnotationProcessor libs.micronaut.inject.annotation.processor
+ testAnnotationProcessor libs.micronaut.validation.annotation.processor
+
+ testImplementation project(':ignite-runner')
+ testImplementation project(':ignite-schema')
+ testImplementation project(':ignite-core')
+ testImplementation project(':ignite-sql-engine')
+ testImplementation(testFixtures(project(":ignite-core")))
+ testImplementation libs.hamcrest.core
+ testImplementation libs.hamcrest.optional
+ testImplementation libs.mockito.junit
+ testImplementation libs.micronaut.junit5
+ testImplementation libs.micronaut.test
+ testImplementation libs.assertj.core
+ testImplementation libs.mock.server.netty
+ testImplementation libs.mock.server.junit
+
+ integrationTestAnnotationProcessor libs.micronaut.inject.annotation.processor
+ integrationTestImplementation project(':ignite-runner')
+ integrationTestImplementation project(':ignite-schema')
+ integrationTestImplementation project(':ignite-sql-engine')
+ integrationTestImplementation(testFixtures(project(":ignite-core")))
+ integrationTestImplementation libs.mock.server.netty
+ integrationTestImplementation libs.mock.server.junit
+ integrationTestImplementation libs.micronaut.junit5
+ integrationTestImplementation libs.micronaut.test
+ integrationTestImplementation libs.assertj.core
+}
+
+ext.generatedClientDir = layout.buildDirectory.dir("swagger/client")
+
+task copyOpenapiDefinition(type: Copy) {
+ from("$rootDir/modules/rest/openapi")
+ into("$buildDir/customOpenapiDefinition/")
+}
+
+task generateApiClient(type: GenerateTask) {
+ generatorName="java"
+ inputs.dir file("$buildDir/customOpenapiDefinition/")
+ inputSpec="$buildDir/customOpenapiDefinition/openapi.yaml"
+ apiPackage="org.apache.ignite.rest.client.api"
+ invokerPackage="org.apache.ignite.rest.client.invoker"
+ modelPackage="org.apache.ignite.rest.client.model"
+ outputDir = generatedClientDir.get().asFile.toString()
+ generateModelTests=false
+ generateApiTests=false
+ languageSpecificPrimitives=["boolean", "int", "float", "double", "char", "byte", "short", "long"]
+ configOptions = [
+ "openApiNullable": "false",
+ "supportStreaming": "false",
+ "library": "okhttp-gson"
+ ]
+}
+
+generateApiClient.dependsOn copyOpenapiDefinition
+
+task generateAutocompletionScript(type: JavaExec) {
+ classpath = sourceSets.main.runtimeClasspath
+ mainClass.set("picocli.AutoComplete")
+ systemProperty("picocli.autocomplete.systemExitOnError", "")
+ args = ["--force",
+ "--completionScript",
+ "${buildDir}/ignite_completion.sh",
+ "-n",
+ "ignite",
+ "org.apache.ignite.cli.commands.TopLevelCliCommand"]
+}
+
+build.dependsOn generateAutocompletionScript
+
+application {
+ mainClass = ' org.apache.ignite.cli.Main'
Review Comment:
```suggestion
mainClass = 'org.apache.ignite.cli.Main'
```
##########
modules/cli/build.gradle:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.openapitools.generator.gradle.plugin.tasks.GenerateTask
+
+plugins {
+ alias(libs.plugins.openapiGenerator)
+ id 'idea'
+ id 'application'
+}
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "$rootDir/buildscripts/java-integration-test.gradle"
+
+description = 'ignite-cli'
+
+dependencies {
+ annotationProcessor libs.picocli.annotation.processor
+ annotationProcessor libs.micronaut.inject.annotation.processor
+ annotationProcessor libs.micronaut.validation.annotation.processor
+
+ implementation project(':ignite-cli-common')
+ implementation project(':ignite-core')
+ implementation project(':ignite-api')
+ implementation project(':ignite-client')
+
+ implementation libs.fliptables
+ implementation libs.jline.core
+ implementation libs.jline.console
+ implementation libs.micronaut.inject
+ implementation libs.micronaut.validation
+ implementation libs.micronaut.runtime
+ implementation libs.micronaut.picocli
+ implementation libs.jansi.core
+ implementation libs.picocli.shell.jline3
+ implementation libs.picocli.core
+ implementation libs.jackson.databind
+ implementation libs.apache.ivy
+ implementation libs.typesafe.config
+ implementation libs.slf4j.jdk14
+ implementation libs.gson.core
+ implementation libs.gson.fire
+ implementation libs.jsr305
+ implementation libs.okhttp.core
+ implementation libs.okhttp.logging
+ implementation libs.threetenbp
+ implementation libs.swagger.legacy.annotations
+
+ testAnnotationProcessor libs.picocli.annotation.processor
+ testAnnotationProcessor libs.micronaut.inject.annotation.processor
+ testAnnotationProcessor libs.micronaut.validation.annotation.processor
+
+ testImplementation project(':ignite-runner')
+ testImplementation project(':ignite-schema')
+ testImplementation project(':ignite-core')
+ testImplementation project(':ignite-sql-engine')
+ testImplementation(testFixtures(project(":ignite-core")))
+ testImplementation libs.hamcrest.core
+ testImplementation libs.hamcrest.optional
+ testImplementation libs.mockito.junit
+ testImplementation libs.micronaut.junit5
+ testImplementation libs.micronaut.test
+ testImplementation libs.assertj.core
+ testImplementation libs.mock.server.netty
+ testImplementation libs.mock.server.junit
+
+ integrationTestAnnotationProcessor libs.micronaut.inject.annotation.processor
+ integrationTestImplementation project(':ignite-runner')
+ integrationTestImplementation project(':ignite-schema')
+ integrationTestImplementation project(':ignite-sql-engine')
+ integrationTestImplementation(testFixtures(project(":ignite-core")))
+ integrationTestImplementation libs.mock.server.netty
+ integrationTestImplementation libs.mock.server.junit
+ integrationTestImplementation libs.micronaut.junit5
+ integrationTestImplementation libs.micronaut.test
+ integrationTestImplementation libs.assertj.core
+}
+
+ext.generatedClientDir = layout.buildDirectory.dir("swagger/client")
+
+task copyOpenapiDefinition(type: Copy) {
+ from("$rootDir/modules/rest/openapi")
+ into("$buildDir/customOpenapiDefinition/")
Review Comment:
What is this copying for?
##########
modules/cli/build.gradle:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.openapitools.generator.gradle.plugin.tasks.GenerateTask
+
+plugins {
+ alias(libs.plugins.openapiGenerator)
+ id 'idea'
+ id 'application'
+}
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "$rootDir/buildscripts/java-integration-test.gradle"
+
+description = 'ignite-cli'
+
+dependencies {
+ annotationProcessor libs.picocli.annotation.processor
+ annotationProcessor libs.micronaut.inject.annotation.processor
+ annotationProcessor libs.micronaut.validation.annotation.processor
+
+ implementation project(':ignite-cli-common')
+ implementation project(':ignite-core')
+ implementation project(':ignite-api')
+ implementation project(':ignite-client')
+
+ implementation libs.fliptables
+ implementation libs.jline.core
+ implementation libs.jline.console
+ implementation libs.micronaut.inject
+ implementation libs.micronaut.validation
+ implementation libs.micronaut.runtime
+ implementation libs.micronaut.picocli
+ implementation libs.jansi.core
+ implementation libs.picocli.shell.jline3
+ implementation libs.picocli.core
+ implementation libs.jackson.databind
+ implementation libs.apache.ivy
+ implementation libs.typesafe.config
+ implementation libs.slf4j.jdk14
+ implementation libs.gson.core
+ implementation libs.gson.fire
+ implementation libs.jsr305
+ implementation libs.okhttp.core
+ implementation libs.okhttp.logging
+ implementation libs.threetenbp
+ implementation libs.swagger.legacy.annotations
+
+ testAnnotationProcessor libs.picocli.annotation.processor
+ testAnnotationProcessor libs.micronaut.inject.annotation.processor
+ testAnnotationProcessor libs.micronaut.validation.annotation.processor
+
+ testImplementation project(':ignite-runner')
+ testImplementation project(':ignite-schema')
+ testImplementation project(':ignite-core')
+ testImplementation project(':ignite-sql-engine')
+ testImplementation(testFixtures(project(":ignite-core")))
+ testImplementation libs.hamcrest.core
+ testImplementation libs.hamcrest.optional
+ testImplementation libs.mockito.junit
+ testImplementation libs.micronaut.junit5
+ testImplementation libs.micronaut.test
+ testImplementation libs.assertj.core
+ testImplementation libs.mock.server.netty
+ testImplementation libs.mock.server.junit
+
+ integrationTestAnnotationProcessor libs.micronaut.inject.annotation.processor
+ integrationTestImplementation project(':ignite-runner')
+ integrationTestImplementation project(':ignite-schema')
+ integrationTestImplementation project(':ignite-sql-engine')
+ integrationTestImplementation(testFixtures(project(":ignite-core")))
+ integrationTestImplementation libs.mock.server.netty
+ integrationTestImplementation libs.mock.server.junit
+ integrationTestImplementation libs.micronaut.junit5
+ integrationTestImplementation libs.micronaut.test
+ integrationTestImplementation libs.assertj.core
+}
+
+ext.generatedClientDir = layout.buildDirectory.dir("swagger/client")
+
+task copyOpenapiDefinition(type: Copy) {
+ from("$rootDir/modules/rest/openapi")
+ into("$buildDir/customOpenapiDefinition/")
+}
+
+task generateApiClient(type: GenerateTask) {
+ generatorName="java"
+ inputs.dir file("$buildDir/customOpenapiDefinition/")
+ inputSpec="$buildDir/customOpenapiDefinition/openapi.yaml"
+ apiPackage="org.apache.ignite.rest.client.api"
+ invokerPackage="org.apache.ignite.rest.client.invoker"
+ modelPackage="org.apache.ignite.rest.client.model"
+ outputDir = generatedClientDir.get().asFile.toString()
+ generateModelTests=false
+ generateApiTests=false
+ languageSpecificPrimitives=["boolean", "int", "float", "double", "char", "byte", "short", "long"]
+ configOptions = [
+ "openApiNullable": "false",
+ "supportStreaming": "false",
+ "library": "okhttp-gson"
+ ]
+}
+
+generateApiClient.dependsOn copyOpenapiDefinition
+
+task generateAutocompletionScript(type: JavaExec) {
+ classpath = sourceSets.main.runtimeClasspath
+ mainClass.set("picocli.AutoComplete")
+ systemProperty("picocli.autocomplete.systemExitOnError", "")
+ args = ["--force",
+ "--completionScript",
+ "${buildDir}/ignite_completion.sh",
+ "-n",
+ "ignite",
+ "org.apache.ignite.cli.commands.TopLevelCliCommand"]
+}
+
+build.dependsOn generateAutocompletionScript
+
+application {
+ mainClass = ' org.apache.ignite.cli.Main'
+}
+
+idea.module {
+ sourceDirs += generatedClientDir.get().dir('src/main/java').asFile
+ resourceDirs += generatedClientDir.get().dir('src/main/resources').asFile
+ generatedSourceDirs += generatedClientDir.get().dir('src/main/java').asFile
+ resourceDirs += sourceSets.main.output.resourcesDir
+}
+
+compileJava {
+ dependsOn generateApiClient
Review Comment:
`generateApiClient` does not depend on `copyOpenapiDefinition`, does it?
##########
modules/metastorage-server/build.gradle:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "$rootDir/buildscripts/java-test-fixtures.gradle"
+
+dependencies {
+ implementation project(':ignite-core')
+ implementation project(':ignite-metastorage-common')
+ implementation project(':ignite-raft-client')
+ implementation project(':ignite-rocksdb-common')
+ implementation libs.jetbrains.annotations
+
+ testImplementation project(':ignite-core')
+ testImplementation(testFixtures(project(':ignite-core')))
+ testImplementation libs.mockito.core
+
+ testFixturesImplementation project(':ignite-core')
+ testFixturesImplementation project(':ignite-metastorage-common')
+ testFixturesImplementation libs.jetbrains.annotations
+}
+
+description = 'ignite-metastorage-server'
+
+//tasks.register('testsJar', Jar) {
Review Comment:
forgotten?
##########
modules/core/build.gradle:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS
+include * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ alias(libs.plugins.shadow)
+}
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "${rootDir}/buildscripts/java-test-fixtures.gradle"
+
+description = 'ignite-core'
+
+dependencies {
+ implementation libs.jetbrains.annotations
+ implementation libs.fastutil.core
+ testImplementation libs.hamcrest.core
+ testImplementation libs.junit.testkit
+ testImplementation libs.mockito.core
+
+ testFixturesImplementation libs.hamcrest.core
+ testFixturesImplementation libs.mockito.core
+ testFixturesImplementation libs.junit.testkit
+ testFixturesImplementation libs.jetbrains.annotations
+ testFixturesImplementation libs.junit5.api
+ testFixturesImplementation libs.junit5.impl
+ testFixturesImplementation libs.junit5.params
+ testFixturesImplementation libs.mockito.core
+}
+
+test {
+ filter {
+ excludeTestsMatching "*VariableSourceTest\$*"
+ excludeTestsMatching "*WorkDirectoryExtensionTest\$*"
Review Comment:
Why do we exclude them?
##########
modules/schema/build.gradle:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: "${rootDir}/buildscripts/java-library.gradle"
+apply from: "$rootDir/buildscripts/java-junit5.gradle"
+apply from: "$rootDir/buildscripts/java-test-fixtures.gradle"
+
+dependencies {
+ implementation project(':ignite-api')
+ implementation project(':ignite-bytecode')
+ implementation project(':ignite-core')
+ implementation project(':ignite-configuration')
+ implementation project(':ignite-extended-api')
+ implementation libs.jetbrains.annotations
+
+ testAnnotationProcessor project(':ignite-configuration-annotation-processor')
+ testImplementation project(':ignite-configuration')
+ testImplementation project(':ignite-core')
+ testImplementation(testFixtures(project(':ignite-core')))
+ testImplementation(testFixtures(project(':ignite-configuration')))
+ testImplementation libs.hamcrest.core
+ testImplementation libs.hamcrest.optional
+ testImplementation libs.mockito.core
+ testImplementation libs.jmh.core
+ testImplementation libs.javax.annotations
+
+ testFixturesImplementation project(':ignite-api')
+ testFixturesImplementation project(':ignite-bytecode')
+ testFixturesImplementation(testFixtures(project(':ignite-core')))
+ testFixturesImplementation libs.junit5.api
+ testFixturesImplementation libs.junit5.impl
+ testFixturesImplementation libs.junit5.params
+}
+
+description = 'ignite-schema'
+
+//tasks.register('testsJar', Jar) {
Review Comment:
commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org