You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/29 02:08:38 UTC
[GitHub] gaodayue commented on issue #6256: RowBasedKeySerde should use
empty dictionary in constructor
gaodayue commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor
URL: https://github.com/apache/incubator-druid/pull/6256#issuecomment-416799333
> Could you please add a comment about why the map is starting out empty (avoiding allocating too much when it's not needed)? Otherwise, a future contributor might not realize it.
Thank you @gianm . It's a good advice, but the PR is merged. Maybe we can add it in future optimization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org