You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2013/07/04 00:06:20 UTC
[jira] [Commented] (ZOOKEEPER-1715) Upgrade netty version
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699506#comment-13699506 ]
Flavio Junqueira commented on ZOOKEEPER-1715:
---------------------------------------------
I came across this jira from the Avro project: AVRO-1292. They suggest the following:
{code}
- channelFuture.awaitUninterruptibly(connectTimeoutMillis);
+ try {
+ channelFuture.await(connectTimeoutMillis);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt(); // Reset interrupt flag
+ throw new IOException("Interrupted while connecting to " +
+ remoteAddr);
+ }
{code}
Should we adopt the same approach?
> Upgrade netty version
> ---------------------
>
> Key: ZOOKEEPER-1715
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1715
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.5
> Environment: zookeeper 3.4.5 uses netty 3.2.2, which was released in August 2010. The latest version of netty is 3.6.6 released May 2013. Zookeeper should consider upgrading.
> Reporter: Sean Bridges
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715.patch
>
>
> Upgrade netty version
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira