You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/07/07 00:33:33 UTC
[GitHub] [arrow] kou opened a new pull request, #36522: GH-36456: [CI][R] Remove system OpenSSL to avoid mixing OpenSSL versions
kou opened a new pull request, #36522:
URL: https://github.com/apache/arrow/pull/36522
### Rationale for this change
If OpenSSL exists in the default path, we may mix OpenSSL in the default path and OpenSSL installed by autobrew. It may cause a link error, run-time symbol not found error and so on.
### What changes are included in this PR?
Ensure removing OpenSSL in the default path.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1628234315
Revision: e79c31e547544790451661715dfae482e24b0d74
Submitted crossbow builds: [ursacomputing/crossbow @ actions-32865d51a3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-32865d51a3)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5504413947/jobs/10030597584)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5504413659/jobs/10030604588)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Remove system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624480842
Revision: 5b00590ffe6c913aedb75599c372c687491cca3a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9bd86161e4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9bd86161e4)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5481529874/jobs/9985934483)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5481529710/jobs/9985942356)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1260411063
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -35,14 +35,20 @@ jobs:
- "{{ macros.r_oldrel.ver }}"
steps:
{{ macros.github_checkout_arrow()|indent }}
+ - name: Setup hosted
+ if: matrix.platform != 'macos-10.13'
+ run: |
+ # minio and sccache are pre-installed on the self-hosted 10.13 runner.
+ # Install minio for tests.
+ brew install minio
+ brew install sccache
+
+ # Ensure removing OpenSSL from the default paths to avoid
+ # mixing OpenSSL in the default paths and OpenSSL installed
+ # by autobrew.
+ brew unlink openssl || :
Review Comment:
https://github.com/ursacomputing/crossbow/actions/runs/5504413947/jobs/10030597584#step:8:19
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -35,14 +35,20 @@ jobs:
- "{{ macros.r_oldrel.ver }}"
steps:
{{ macros.github_checkout_arrow()|indent }}
+ - name: Setup hosted
+ if: matrix.platform != 'macos-10.13'
+ run: |
+ # minio and sccache are pre-installed on the self-hosted 10.13 runner.
+ # Install minio for tests.
+ brew install minio
+ brew install sccache
+
+ # Ensure removing OpenSSL from the default paths to avoid
+ # mixing OpenSSL in the default paths and OpenSSL installed
+ # by autobrew.
+ brew unlink openssl || :
Review Comment:
https://github.com/ursacomputing/crossbow/actions/runs/5504413947/jobs/10030597584#step:8:19
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -72,8 +78,10 @@ jobs:
ARROW_USE_PKG_CONFIG: false
ARROW_R_DEV: true
FORCE_AUTOBREW: true
- {{ macros.github_set_sccache_envvars()|indent(8)}}
- run: arrow/ci/scripts/r_test.sh arrow
+ {{ macros.github_set_sccache_envvars()|indent(8)}}
+ run: |
+ find / 2>&1 | grep include/openssl || :
+ arrow/ci/scripts/r_test.sh arrow
Review Comment:
https://github.com/ursacomputing/crossbow/actions/runs/5504413947/jobs/10030597584#step:8:19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1628229865
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1627630180
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1631667941
Oh great it looks like dewey was able to repro locally and fix the underlying issue in #36551 :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Remove system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624474999
Revision: a9819c534230e95761e62893023bf02651530720
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2469721177](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2469721177)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5481478334/jobs/9985824666)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5481478190/jobs/9985832272)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1260509392
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -72,8 +78,10 @@ jobs:
ARROW_USE_PKG_CONFIG: false
ARROW_R_DEV: true
FORCE_AUTOBREW: true
- {{ macros.github_set_sccache_envvars()|indent(8)}}
- run: arrow/ci/scripts/r_test.sh arrow
+ {{ macros.github_set_sccache_envvars()|indent(8)}}
+ run: |
+ find / 2>&1 | grep include/openssl || :
+ arrow/ci/scripts/r_test.sh arrow
Review Comment:
Yes. It's just a debug print.
I want to find OpenSSl header files in the system but I couldn't find them...
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -35,14 +35,20 @@ jobs:
- "{{ macros.r_oldrel.ver }}"
steps:
{{ macros.github_checkout_arrow()|indent }}
+ - name: Setup hosted
+ if: matrix.platform != 'macos-10.13'
+ run: |
+ # minio and sccache are pre-installed on the self-hosted 10.13 runner.
+ # Install minio for tests.
+ brew install minio
+ brew install sccache
+
+ # Ensure removing OpenSSL from the default paths to avoid
+ # mixing OpenSSL in the default paths and OpenSSL installed
+ # by autobrew.
+ brew unlink openssl || :
Review Comment:
I think that it's difficult.
For example, please consider the following case:
* OpenSSL 1.1 is installed in `/usr/local`
* OpenSSL 3 is install in `/opt/openssl`
* c-ares is installed in `/usr/local`
* Build bundled gRPC with c-ares and OpenSSL 3
* gRPC uses `-I/usr/local/include` from c-ares and `-I/opt/openssl/include` from OpenSSL 3
* `-I/opt/openssl/include -I/usr/local/include` will work but `-I/usr/local/include -I/opt/openssl/include` will not work because OpenSSl 1.1 headers in `/usr/local/include` are used
* I don't think that we can always use include flags from OpenSSL 3 as the first include flag because there are more version mixable libraries such as Abseil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1628163661
Revision: 42dd6231a2eca2dbe94f5b5fca14b72d3c7cc4e5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1cf795e683](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1cf795e683)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5504150615/jobs/10030063425)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5504150836/jobs/10030070916)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624506375
In general, it'll not happen on user environments because Homebrew's OpenSSL packages don't put symlinks to the default path by default. (If you're interested in it, please search "keg-only".)
But GitHub Actions runs `brew link openssl` explicitly to put symlinks to the default path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1258375262
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -35,14 +35,20 @@ jobs:
- "{{ macros.r_oldrel.ver }}"
steps:
{{ macros.github_checkout_arrow()|indent }}
+ - name: Setup hosted
+ if: matrix.platform != 'macos-10.13'
+ run: |
+ # minio and sccache are pre-installed on the self-hosted 10.13 runner.
+ # Install minio for tests.
+ brew install minio
+ brew install sccache
+
+ # Ensure removing OpenSSL from the default paths to avoid
+ # mixing OpenSSL in the default paths and OpenSSL installed
+ # by autobrew.
+ brew unlink openssl || :
Review Comment:
Hmm... can we instead make sure our build chain selects OpenSSL consistently? Users will otherwise probably encounter a similar problem if they try compiling Arrow themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1628159682
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1627630609
Revision: 67f7d7dc5f75428af083f7857aca28bbb7bba0a3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-70f9771dc0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-70f9771dc0)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5498627703/jobs/10020229281)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5498627513/jobs/10020233672)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624512632
Ah interesting, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1260410678
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -35,14 +35,20 @@ jobs:
- "{{ macros.r_oldrel.ver }}"
steps:
{{ macros.github_checkout_arrow()|indent }}
+ - name: Setup hosted
+ if: matrix.platform != 'macos-10.13'
+ run: |
+ # minio and sccache are pre-installed on the self-hosted 10.13 runner.
+ # Install minio for tests.
+ brew install minio
+ brew install sccache
+
+ # Ensure removing OpenSSL from the default paths to avoid
+ # mixing OpenSSL in the default paths and OpenSSL installed
+ # by autobrew.
+ brew unlink openssl || :
Review Comment:
That would also be my preference though it seems to be tricky and I haven't had the time to investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624494260
This will fix our nightly build but could this not also happen when users build from scratch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624526657
Revision: bf9bf449c1a458b0fb38c15b3122298e973b52f5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-aad7680fbf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-aad7680fbf)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5481909412/jobs/9986718175)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5481909151/jobs/9986726218)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1631779052
I close this in favor of #36551.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1627986526
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Remove system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624479291
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624524068
Oh... This doesn't resolve this problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1627831035
Revision: a1e0265edf9e47f9f577625f5367fbb4e8c36e55
Submitted crossbow builds: [ursacomputing/crossbow @ actions-36db938171](https://github.com/ursacomputing/crossbow/branches/all?query=actions-36db938171)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5502038239/jobs/10026028499)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5502038350/jobs/10026033956)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1627830567
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624525056
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1258376431
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -72,8 +78,10 @@ jobs:
ARROW_USE_PKG_CONFIG: false
ARROW_R_DEV: true
FORCE_AUTOBREW: true
- {{ macros.github_set_sccache_envvars()|indent(8)}}
- run: arrow/ci/scripts/r_test.sh arrow
+ {{ macros.github_set_sccache_envvars()|indent(8)}}
+ run: |
+ find / 2>&1 | grep include/openssl || :
+ arrow/ci/scripts/r_test.sh arrow
Review Comment:
I'm a bit embarassed, but I don't understand what these two lines do...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1260409754
##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -72,8 +78,10 @@ jobs:
ARROW_USE_PKG_CONFIG: false
ARROW_R_DEV: true
FORCE_AUTOBREW: true
- {{ macros.github_set_sccache_envvars()|indent(8)}}
- run: arrow/ci/scripts/r_test.sh arrow
+ {{ macros.github_set_sccache_envvars()|indent(8)}}
+ run: |
+ find / 2>&1 | grep include/openssl || :
+ arrow/ci/scripts/r_test.sh arrow
Review Comment:
I think the first line is just for debug purposes printing all find hits of include/openssl or nothing. The script setup an env for r testing and then test/checks the r package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
URL: https://github.com/apache/arrow/pull/36522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Remove system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624473359
:warning: GitHub issue #36456 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36522: GH-36456: [CI][R] Remove system OpenSSL to avoid mixing OpenSSL versions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1624473425
@github-actions crossbow submit r-binary-packages homebrew-r-autobrew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36522:
URL: https://github.com/apache/arrow/pull/36522#issuecomment-1627988504
Revision: 9ea58239e42adee031f57bb26df76165f3a2e336
Submitted crossbow builds: [ursacomputing/crossbow @ actions-eafc75adab](https://github.com/ursacomputing/crossbow/branches/all?query=actions-eafc75adab)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5503420730/jobs/10028613645)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5503421057/jobs/10028621562)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org