You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/19 02:21:29 UTC
[GitHub] [arrow] kou opened a new pull request, #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
kou opened a new pull request, #35680:
URL: https://github.com/apache/arrow/pull/35680
### Rationale for this change
Large/small double values are truncated with MinGW 32bit. We can skip tests that depend on large/small double values with MinGW 32bit or change expected values for these cases.
```text
[----------] 2 tests from TestDecimalFromReal/1, where TypeParam = std::pair<arrow::Decimal128, double>
[ RUN ] TestDecimalFromReal/1.TestSuccess
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "4611686000000000000"
expected
Which is: "4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-4611686000000000000"
expected
Which is: "-4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "9223372000000000000"
expected
Which is: "9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-9223372000000000000"
expected
Which is: "-9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "18446744000000000000"
expected
Which is: "18446744073709551616"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-18446744000000000000"
expected
Which is: "-18446744073709551616"
[ FAILED ] TestDecimalFromReal/1.TestSuccess, where TypeParam = std::pair<arrow::Decimal128, double> (0 ms)
[ RUN ] TestDecimalFromReal/1.TestErrors
[ OK ] TestDecimalFromReal/1.TestErrors (0 ms)
[----------] 2 tests from TestDecimalFromReal/1 (0 ms total)
[----------] 2 tests from TestDecimalFromReal/2, where TypeParam = std::pair<arrow::Decimal256, float>
[ RUN ] TestDecimalFromReal/2.TestSuccess
[ OK ] TestDecimalFromReal/2.TestSuccess (0 ms)
[ RUN ] TestDecimalFromReal/2.TestErrors
[ OK ] TestDecimalFromReal/2.TestErrors (0 ms)
[----------] 2 tests from TestDecimalFromReal/2 (0 ms total)
[----------] 2 tests from TestDecimalFromReal/3, where TypeParam = std::pair<arrow::Decimal256, double>
[ RUN ] TestDecimalFromReal/3.TestSuccess
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "4611686000000000000"
expected
Which is: "4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-4611686000000000000"
expected
Which is: "-4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "9223372000000000000"
expected
Which is: "9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-9223372000000000000"
expected
Which is: "-9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "18446744000000000000"
expected
Which is: "18446744073709551616"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-18446744000000000000"
expected
Which is: "-18446744073709551616"
[ FAILED ] TestDecimalFromReal/3.TestSuccess, where TypeParam = std::pair<arrow::Decimal256, double> (0 ms)
[ RUN ] TestDecimalFromReal/3.TestErrors
```
### What changes are included in this PR?
This changes expected values only for MinGW 32bit.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1554767771
Can we merge this patch now, long time didn't see all CI passed ... @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553914647
* Closes: #35606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1556244659
Benchmark runs are scheduled for baseline = 61447d95c57a6e416991c383892460e020547c9d and contender = 3f736ff1eb0ca750153fce7c851c2cbab6c75b6e. 3f736ff1eb0ca750153fce7c851c2cbab6c75b6e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ae0137fff3d9429e94294ddff40e065d...1ba946c1ab2645da98e5db3fd129c08a/)
[Finished :arrow_down:0.33% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4fdb77d49fe84c058ff533bae6997437...0424f39ea42547d0933e9c82f9eddd46/)
[Finished :arrow_down:0.65% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1817fd3f5d57493eb925e484d24f545f...026b582011b24b02b2d484f9614be2d7/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/76dbc41f466a41f0bdaa50fd8ed74301...52226271e8654363a80bbe209f9784f0/)
Buildkite builds:
[Finished] [`3f736ff1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2902)
[Finished] [`3f736ff1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2938)
[Finished] [`3f736ff1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2903)
[Finished] [`3f736ff1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2928)
[Finished] [`61447d95` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2901)
[Finished] [`61447d95` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2937)
[Finished] [`61447d95` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2902)
[Finished] [`61447d95` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2927)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1554255451
Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1556244962
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1817fd3f5d57493eb925e484d24f545f...026b582011b24b02b2d484f9614be2d7/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553914671
:warning: GitHub issue #35606 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553943827
Got it. Seems it could be reproduce in all 32-bits system? I'm curious why previous CI didn't found it, does it because different compiler version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553976635
@pitrou Which approach (update expected or update inputs) do you like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553976117
Note: SEGV in MinGW 64bit can be fixed by #35663 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553970870
> Seems it could be reproduce in all 32-bits system?
Ah, maybe?
> I'm curious why previous CI didn't found it, does it because different compiler version?
I think so.
The last success log uses GCC 12.2.0: https://github.com/apache/arrow/actions/runs/4887879991/jobs/8724979317#step:5:82
The first failure log uses GCC 13.1.0: https://github.com/apache/arrow/actions/runs/4903414370/jobs/8755848221#step:5:82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553941222
Because inputs (such as `4.611686e+18`) doesn't have enough precision. If we use inputs that have more precision such as `4.6116860184273879e+18`, we can get expected value with MinGW 32bit too.
I've pushed the approach as a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553942872
If we choose the approach, we should update the title and description of this pull request before we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1553922851
Hi @kou, do you have any explainations that why MinGW truncate expected values? It's that the only 32-bits cases in our CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Truncate expected values too
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1554049371
I'm +1 for current solution, seems explicit mark `4611686018427387904` is better than `4.6...e`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1554058343
I've updated the title and description for the current approach (update inputs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35680:
URL: https://github.com/apache/arrow/pull/35680#issuecomment-1554247341
The solution is ok to me, though this really looks like in a MinGW32 bug (also, it used to work fine). Can you rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35680: GH-35606: [CI][C++][MinGW32] Use more accurate float inputs for decimal test
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35680:
URL: https://github.com/apache/arrow/pull/35680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org