[GitHub] [spark] amaliujia commented on a diff in pull request #40315: [SPARK-42699][CONNECT] SparkConnectServer should make client and AM same exit code

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #40315:
URL: https://github.com/apache/spark/pull/40315#discussion_r1131780390


##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -737,12 +737,19 @@ class SparkSession private(
   // scalastyle:on
 
   /**
-   * Stop the underlying `SparkContext`.
+   * Stop the underlying `SparkContext` with default exit code 0.
    *
    * @since 2.0.0
    */
-  def stop(): Unit = {
-    sparkContext.stop()
+  def stop(): Unit = stop(0)

Review Comment:
   I think it is better to not change this line. This line builds on `sparkContext.stop()`. Even though the underlying implementation is `SparkContext.stop(0)`, I think we'd better do not make that assumption that it will always be.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org