You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Regina Henschel <rb...@t-online.de> on 2012/01/09 21:00:00 UTC
New feature: Drawing thick lines with line caps
Hi all,
in ODF (and in SVG) exists the feature, that a thick line can get round
or square line caps at the end of the line. Those caps are added to the
single parts too, if the line is dashed.
I have started to implement that features. Because Armin had re-factored
(some years ago) the internal to use primitives, I could get it work
till you see those line caps on screen. Unfortunately there are still
some parts in Draw which are very old and confusing. Here Armin has
jumped in and added the missing parts.
You can have a look at this upcoming feature in the branch
https://svn.apache.org/repos/asf/incubator/ooo/branches/alg/linecap
An intermediate Windows build is available from
http://people.apache.org/~alg/wntmsci12/setup.zip.
Kind regards
Regina
Re: New feature: Drawing thick lines with line caps
Posted by Regina Henschel <rb...@t-online.de>.
Hi Andrea,
Andrea Pescetti schrieb:
> On 16/01/2012 Regina Henschel wrote:
>> I have added a Wiki page about it
>> https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.4+Release+Notes
>>
>
> Thanks Regina (and Armin for technical details and integration work),
> this is a very nice description!
>
> Just a question: does this new feature introduce new strings? If so,
> then we might need to start a separate discussion on how to manage
> translations of new strings.
Yes. The strings in the UI (see screenshot) are new. But I don't know
the workflow for translations.
Texts for extended tips and help texts are not included and will come later.
Kind regards
Regina
Re: New feature: Drawing thick lines with line caps
Posted by Andrea Pescetti <pe...@apache.org>.
On 16/01/2012 Regina Henschel wrote:
> I have added a Wiki page about it
> https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.4+Release+Notes
Thanks Regina (and Armin for technical details and integration work),
this is a very nice description!
Just a question: does this new feature introduce new strings? If so,
then we might need to start a separate discussion on how to manage
translations of new strings.
Regards,
Andrea.
Re: New feature: Drawing thick lines with line caps
Posted by Regina Henschel <rb...@t-online.de>.
Hi Andrea,
Andrea Pescetti schrieb:
> On 13/01/2012 Armin Le Grand wrote:
>> again updated to trunk (after some Svg fixes) and built. Find the
>> linecap install sets under:
>> Win: http://people.apache.org/~alg/linecap/wntmsci12/
>> Linux64bit: http://people.apache.org/~alg/linecap/unxlngx6/
>> Have fun checking out the LineCap feature!
>
> Thanks Regina, Armin,
> but would it be possible to have just a couple screenshots with "Before
> and After" the Linecap feature, for those who are not familiar with
> terminology and can't install the builds you provided? It's all stuff
> that we will need to reuse in the release notes anyway, and useful
> information for potential testers.
I have added a Wiki page about it
https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.4+Release+Notes
[Feel free to correct it, I'm no native English speaker.]
Kind regards
Regina
Re: New feature: Drawing thick lines with line caps
Posted by Armin Le Grand <Ar...@me.com>.
Hi Andrea,
On 14.01.2012 23:32, Andrea Pescetti wrote:
> On 13/01/2012 Armin Le Grand wrote:
>> again updated to trunk (after some Svg fixes) and built. Find the
>> linecap install sets under:
>> Win: http://people.apache.org/~alg/linecap/wntmsci12/
>> Linux64bit: http://people.apache.org/~alg/linecap/unxlngx6/
>> Have fun checking out the LineCap feature!
>
> Thanks Regina, Armin,
> but would it be possible to have just a couple screenshots with "Before
> and After" the Linecap feature, for those who are not familiar with
> terminology and can't install the builds you provided? It's all stuff
> that we will need to reuse in the release notes anyway, and useful
> information for potential testers.
Well, screenshots would be stripped from the newsgroup, but I can at
least offer this link
(http://www.w3.org/TR/2003/REC-SVG11-20030114/painting.html#StrokeLinecapProperty)
to the Svg definition of w3.org. This feature is pretty much exactly
about that. OOo did never support it, but pretty much all other graphic
systems/definitions do nowadays. The feature is about integrating this
into AOO, UI, core, Odf, painting, printing, exports, imports, etc. In
short everywhere where it will be useful.
>
> Regards,
> Andrea.
>
HTH!
Sincerely,
Armin
--
ALG
Re: New feature: Drawing thick lines with line caps
Posted by Andrea Pescetti <pe...@apache.org>.
On 13/01/2012 Armin Le Grand wrote:
> again updated to trunk (after some Svg fixes) and built. Find the
> linecap install sets under:
> Win: http://people.apache.org/~alg/linecap/wntmsci12/
> Linux64bit: http://people.apache.org/~alg/linecap/unxlngx6/
> Have fun checking out the LineCap feature!
Thanks Regina, Armin,
but would it be possible to have just a couple screenshots with "Before
and After" the Linecap feature, for those who are not familiar with
terminology and can't install the builds you provided? It's all stuff
that we will need to reuse in the release notes anyway, and useful
information for potential testers.
Regards,
Andrea.
Re: New feature: Drawing thick lines with line caps
Posted by Armin Le Grand <Ar...@me.com>.
Hi all,
again updated to trunk (after some Svg fixes) and built. Find the
linecap install sets under:
Win: http://people.apache.org/~alg/linecap/wntmsci12/
Linux64bit: http://people.apache.org/~alg/linecap/unxlngx6/
Have fun checking out the LineCap feature!
Armin
--
ALG
Re: New feature: Drawing thick lines with line caps
Posted by Armin Le Grand <Ar...@me.com>.
Hi Pavel,
On 17.01.2012 21:29, Pavel Janík wrote:
> Armin,
>
> On Jan 17, 2012, at 6:56 PM, Armin Le Grand wrote:
>
>> I have reintegrated the finished feature from the branch to trunk. Kudos go to Regina for the basic implementation and for offering it here.
>
> can you please have a look at the code? This NOT-TO-BE-INTEGRATED change shows the WaE issue in vcl:
Thanks, added mac code as needed (wondering why the mac build I made
yesterday worked well and showed linecaps as intended)...
> --- vcl.orig/aqua/source/gdi/salgdi.cxx 2012-01-17 19:51:19.000000000 +0100
> +++ vcl/aqua/source/gdi/salgdi.cxx 2012-01-17 19:52:07.000000000 +0100
> @@ -987,6 +987,7 @@
> basegfx::B2DLineJoin eLineJoin,
> com::sun::star::drawing::LineCap eLineCap)
> {
> + (void)eLineCap; // Unused parameter...
> // short circuit if there is nothing to do
> const int nPointCount = rPolyLine.count();
> if( nPointCount<= 0 )
>
> And this one should be integrated:
Changed, done. Thanks!
> --- svx.orig/source/xoutdev/xattr2.cxx 2012-01-17 21:21:03.000000000 +0100
> +++ svx/source/xoutdev/xattr2.cxx 2012-01-17 21:28:40.000000000 +0100
> @@ -451,7 +451,7 @@
> || com::sun::star::drawing::LineCap_ROUND == eRetval
> || com::sun::star::drawing::LineCap_SQUARE == eRetval, "Unknown enum value in XATTR_LINECAP (!)");
>
> - return (com::sun::star::drawing::LineCap)SfxEnumItem::GetValue();
> + return eRetval;
> }
>
> //------------------------------
>
Sincerely,
Armin
--
ALG
Re: New feature: Drawing thick lines with line caps
Posted by Pavel Janík <Pa...@Janik.cz>.
Armin,
On Jan 17, 2012, at 6:56 PM, Armin Le Grand wrote:
> I have reintegrated the finished feature from the branch to trunk. Kudos go to Regina for the basic implementation and for offering it here.
can you please have a look at the code? This NOT-TO-BE-INTEGRATED change shows the WaE issue in vcl:
--- vcl.orig/aqua/source/gdi/salgdi.cxx 2012-01-17 19:51:19.000000000 +0100
+++ vcl/aqua/source/gdi/salgdi.cxx 2012-01-17 19:52:07.000000000 +0100
@@ -987,6 +987,7 @@
basegfx::B2DLineJoin eLineJoin,
com::sun::star::drawing::LineCap eLineCap)
{
+ (void)eLineCap; // Unused parameter...
// short circuit if there is nothing to do
const int nPointCount = rPolyLine.count();
if( nPointCount <= 0 )
And this one should be integrated:
--- svx.orig/source/xoutdev/xattr2.cxx 2012-01-17 21:21:03.000000000 +0100
+++ svx/source/xoutdev/xattr2.cxx 2012-01-17 21:28:40.000000000 +0100
@@ -451,7 +451,7 @@
|| com::sun::star::drawing::LineCap_ROUND == eRetval
|| com::sun::star::drawing::LineCap_SQUARE == eRetval, "Unknown enum value in XATTR_LINECAP (!)");
- return (com::sun::star::drawing::LineCap)SfxEnumItem::GetValue();
+ return eRetval;
}
//------------------------------
--
Pavel Janík
Re: New feature: Drawing thick lines with line caps
Posted by Armin Le Grand <Ar...@me.com>.
Hi all,
I have reintegrated the finished feature from the branch to trunk. Kudos
go to Regina for the basic implementation and for offering it here.
Sincerely,
Armin
--
ALG
Re: New feature: Drawing thick lines with line caps
Posted by Armin Le Grand <Ar...@me.com>.
Hi all,
I updated a last time to trunk, the feature is ready. Builds can be
found at:
Linux64bit: http://people.apache.org/~alg/linecap/unxlngx6/
Mac: http://people.apache.org/~alg/linecap/unxmacxi/
Windows: http://people.apache.org/~alg/linecap/wntmsci12/
Sincerely,
Armin
--
ALG
Re: New feature: Drawing thick lines with line caps
Posted by Armin Le Grand <Ar...@me.com>.
Hi all,
I've now updated the branch
https://svn.apache.org/repos/asf/incubator/ooo/branches/alg/linecap to
trunk and rebuilt, lot of Svg fixes added. I uploaded the fresh build
(windows version) to http://people.apache.org/~alg/wntmsci12/setup.zip
if you want to take a look. It supports all exports now, 2D and 3D line
geometry creation with caps and works well when breaking imported Svg
with lineCaps definitions.
On 09.01.2012 21:00, Regina Henschel wrote:
> Hi all,
>
> in ODF (and in SVG) exists the feature, that a thick line can get round
> or square line caps at the end of the line. Those caps are added to the
> single parts too, if the line is dashed.
>
> I have started to implement that features. Because Armin had re-factored
> (some years ago) the internal to use primitives, I could get it work
> till you see those line caps on screen. Unfortunately there are still
> some parts in Draw which are very old and confusing. Here Armin has
> jumped in and added the missing parts.
>
> You can have a look at this upcoming feature in the branch
> https://svn.apache.org/repos/asf/incubator/ooo/branches/alg/linecap
> An intermediate Windows build is available from
> http://people.apache.org/~alg/wntmsci12/setup.zip.
>
> Kind regards
> Regina
Sincerely,
Armin
--
ALG