[GitHub] [superset] michael-s-molina commented on pull request #24176: fix: Time shifts with different granularity for ECharts

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on PR #24176:
URL: https://github.com/apache/superset/pull/24176#issuecomment-1572148485

   > 1. IMO, the renaming/refining of TimeGrain should be put in a separate chore pull request rather than this one.
   
   I could do that but I guess I was excited to fix the problem and ended up doing all at once. Sorry if this makes it more difficult to review but I think the important part is that I took the time to improve the code base.
   
   > 2. I can't get result of your screenshot. (on this PR branch)
   
   It was not working indeed with `GENERIC_CHART_AXES` enabled because the query object didn't contain a `time_grain_sqla` field. I submitted a fix to get this from the `form_data` and now it should be working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org