[GitHub] [spark] gengliangwang commented on pull request #39827: [WIP][SPARK-36180][SQL] Support TimestampNTZ type in Hive metastore

["gengliangwang (via GitHub)" <gi...@apache.org>]

gengliangwang commented on PR #39827:
URL: https://github.com/apache/spark/pull/39827#issuecomment-1412989880

   > I don't know the reason. It seems the feature support restart.
   
   We are going to release TimestampNTZ in Spark 3.4.0.
   
   > Could you tell me the distinct between this PR and https://github.com/apache/spark/pull/39827 ?
   
   Do you mean the difference from https://github.com/apache/spark/pull/34647? This one is trying to change the catalogString of TimestampNTZ and compare catalog strings of Hive table schema and Spark written schema. From the test results, I think this is a bad approach.
   Note that we don't have to support this for now. I think supporting all the built-in file sources (except text) is enough for the 3.4.0 release.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org