[GitHub] [helix] jiajunwang commented on a change in pull request #1218: Fix ClusterManager thread leak

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r465915122



##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
    * Randomly causes Participants to lost connection temporarily.
    */
   private void breakConnection() {
+    // Note, send to THREAD_COUNT == 1 is a must to avoid leaking ClusterManager (participant).

Review comment:
       I suspect THREAD_COUNT > 1 is the test requirement here. But I'm not sure. @narendly, could you please comment here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org