You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:36:26 UTC
[GitHub] [cordova-plugin-splashscreen] erisu commented on a diff in pull request #337: feat(android)!: remove platform from plugin
erisu commented on code in PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#discussion_r966122259
##########
package.json:
##########
@@ -27,15 +25,10 @@
},
"engines": {
"cordovaDependencies": {
- "2.0.0": {
Review Comment:
Maybe it could be kept, but I don't think such information is necessary to keep as we can pull up the JSON file from the tag.
I also don't know if these versions were ever used. We had to declare the same information in plugin.xml file for the version that was being installed. I think it was read from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org