You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/02/12 18:04:49 UTC

Review Request 18018: Security_enabled was not send when adding service. Add service failed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18018/
-----------------------------------------------------------

Review request for Ambari and Eugene Chekanskiy.


Bugs: AMBARI-4633
    https://issues.apache.org/jira/browse/AMBARI-4633


Repository: ambari


Description
-------

We are sending security_enabled parameter. If it's not present it's a bug that will hit web-ui behavior. 
But this parameter is solely used by web-ui code. Puppet uses _core-site/hadoop.security.authentication_ for determining cluster security status.
The relevant code is at {{ambari-agent/src/main/puppet/modules/hdp/manifests/params.pp}}
{code}
##### for secure install
  $hadoop_security_authenticatoin = hdp_default("core-site/hadoop.security.authentication", "simple")
  
  $security_enabled = $hadoop_security_authenticatoin ? {
    'kerberos' => true,
    default => false,
  }
{code}


Diffs
-----

  ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py 710c9c6 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 211c2bb 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 923b6ce 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 0e26060 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py a9d3e9c 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py 47b2db0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 1b2668e 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py 93f3dd1 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py 636f882 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/package/scripts/params.py 21a39d9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 804a654 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 3c02248 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 1955a3c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 0422a7c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py bc1494f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 7ed4322 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 8754930 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 463dccc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 636f882 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py 7de3367 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 75aa75c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py fb8e51a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 3c02248 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 88499ba 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0cf89be 

Diff: https://reviews.apache.org/r/18018/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 18018: Security_enabled was not send when adding service. Add service failed

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18018/#review34408
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 13, 2014, 7:43 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18018/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 7:43 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4633
>     https://issues.apache.org/jira/browse/AMBARI-4633
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We are sending security_enabled parameter. If it's not present it's a bug that will hit web-ui behavior. 
> But this parameter is solely used by web-ui code. Puppet uses _core-site/hadoop.security.authentication_ for determining cluster security status.
> The relevant code is at {{ambari-agent/src/main/puppet/modules/hdp/manifests/params.pp}}
> {code}
> ##### for secure install
>   $hadoop_security_authenticatoin = hdp_default("core-site/hadoop.security.authentication", "simple")
>   
>   $security_enabled = $hadoop_security_authenticatoin ? {
>     'kerberos' => true,
>     default => false,
>   }
> {code}
> 
> We should do the same thing in out python code. We should not depend on secutiry_enabled flag being set by UI.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/libraries/functions/__init__.py db3fc87 
>   ambari-agent/src/main/python/resource_management/libraries/functions/is_empty.py PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py bba131a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py d054fce 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5fe3881 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 3c22a2c 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 1a0dd43 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py 9da3e18 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/functions.py 964225e 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 0eca3a6 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py 951fd61 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py 4c4880f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/package/scripts/params.py a2f4fb9 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 7d83f94 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 72e1e37 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py bb13d7f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py e522e12 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py cb6b407 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py e9c9554 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/functions.py 964225e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 07ce4b0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py c0005f7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 4c4880f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py c1e1fbf 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py ffa5667 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 92a536c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 72e1e37 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py a99dcaa 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 89647d8 
> 
> Diff: https://reviews.apache.org/r/18018/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 18018: Security_enabled was not send when adding service. Add service failed

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18018/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 7:43 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-4633
    https://issues.apache.org/jira/browse/AMBARI-4633


Repository: ambari


Description
-------

We are sending security_enabled parameter. If it's not present it's a bug that will hit web-ui behavior. 
But this parameter is solely used by web-ui code. Puppet uses _core-site/hadoop.security.authentication_ for determining cluster security status.
The relevant code is at {{ambari-agent/src/main/puppet/modules/hdp/manifests/params.pp}}
{code}
##### for secure install
  $hadoop_security_authenticatoin = hdp_default("core-site/hadoop.security.authentication", "simple")
  
  $security_enabled = $hadoop_security_authenticatoin ? {
    'kerberos' => true,
    default => false,
  }
{code}

We should do the same thing in out python code. We should not depend on secutiry_enabled flag being set by UI.


Diffs (updated)
-----

  ambari-agent/src/main/python/resource_management/libraries/functions/__init__.py db3fc87 
  ambari-agent/src/main/python/resource_management/libraries/functions/is_empty.py PRE-CREATION 
  ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py bba131a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py d054fce 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5fe3881 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 3c22a2c 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 1a0dd43 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py 9da3e18 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/functions.py 964225e 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 0eca3a6 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py 951fd61 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py 4c4880f 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/package/scripts/params.py a2f4fb9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 7d83f94 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 72e1e37 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py bb13d7f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py e522e12 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py cb6b407 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py e9c9554 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/functions.py 964225e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 07ce4b0 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py c0005f7 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 4c4880f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py c1e1fbf 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py ffa5667 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 92a536c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 72e1e37 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py a99dcaa 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 89647d8 

Diff: https://reviews.apache.org/r/18018/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 18018: Security_enabled was not send when adding service. Add service failed

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18018/#review34294
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 12, 2014, 5:07 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18018/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 5:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4633
>     https://issues.apache.org/jira/browse/AMBARI-4633
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We are sending security_enabled parameter. If it's not present it's a bug that will hit web-ui behavior. 
> But this parameter is solely used by web-ui code. Puppet uses _core-site/hadoop.security.authentication_ for determining cluster security status.
> The relevant code is at {{ambari-agent/src/main/puppet/modules/hdp/manifests/params.pp}}
> {code}
> ##### for secure install
>   $hadoop_security_authenticatoin = hdp_default("core-site/hadoop.security.authentication", "simple")
>   
>   $security_enabled = $hadoop_security_authenticatoin ? {
>     'kerberos' => true,
>     default => false,
>   }
> {code}
> 
> We should do the same thing in out python code. We should not depend on secutiry_enabled flag being set by UI.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py 710c9c6 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 211c2bb 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 923b6ce 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 0e26060 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py a9d3e9c 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py 47b2db0 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 1b2668e 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py 93f3dd1 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py 636f882 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/package/scripts/params.py 21a39d9 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 804a654 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 3c02248 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 1955a3c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 0422a7c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py bc1494f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 7ed4322 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 8754930 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 463dccc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 636f882 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py 7de3367 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 75aa75c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py fb8e51a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 3c02248 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 88499ba 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0cf89be 
> 
> Diff: https://reviews.apache.org/r/18018/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 18018: Security_enabled was not send when adding service. Add service failed

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18018/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 5:07 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-4633
    https://issues.apache.org/jira/browse/AMBARI-4633


Repository: ambari


Description
-------

We are sending security_enabled parameter. If it's not present it's a bug that will hit web-ui behavior. 
But this parameter is solely used by web-ui code. Puppet uses _core-site/hadoop.security.authentication_ for determining cluster security status.
The relevant code is at {{ambari-agent/src/main/puppet/modules/hdp/manifests/params.pp}}
{code}
##### for secure install
  $hadoop_security_authenticatoin = hdp_default("core-site/hadoop.security.authentication", "simple")
  
  $security_enabled = $hadoop_security_authenticatoin ? {
    'kerberos' => true,
    default => false,
  }
{code}

We should do the same thing in out python code. We should not depend on secutiry_enabled flag being set by UI.


Diffs
-----

  ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py 710c9c6 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 211c2bb 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 923b6ce 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 0e26060 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py a9d3e9c 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py 47b2db0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 1b2668e 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py 93f3dd1 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py 636f882 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/package/scripts/params.py 21a39d9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 804a654 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 3c02248 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 1955a3c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 0422a7c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py bc1494f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 7ed4322 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 8754930 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 463dccc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 636f882 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py 7de3367 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 75aa75c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py fb8e51a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 3c02248 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 88499ba 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0cf89be 

Diff: https://reviews.apache.org/r/18018/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 18018: Security_enabled was not send when adding service. Add service failed

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18018/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 5:06 p.m.)


Review request for Ambari and Eugene Chekanskiy.


Bugs: AMBARI-4633
    https://issues.apache.org/jira/browse/AMBARI-4633


Repository: ambari


Description (updated)
-------

We are sending security_enabled parameter. If it's not present it's a bug that will hit web-ui behavior. 
But this parameter is solely used by web-ui code. Puppet uses _core-site/hadoop.security.authentication_ for determining cluster security status.
The relevant code is at {{ambari-agent/src/main/puppet/modules/hdp/manifests/params.pp}}
{code}
##### for secure install
  $hadoop_security_authenticatoin = hdp_default("core-site/hadoop.security.authentication", "simple")
  
  $security_enabled = $hadoop_security_authenticatoin ? {
    'kerberos' => true,
    default => false,
  }
{code}

We should do the same thing in out python code. We should not depend on secutiry_enabled flag being set by UI.


Diffs
-----

  ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalancer.py 710c9c6 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 211c2bb 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 923b6ce 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 0e26060 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py a9d3e9c 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py 47b2db0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 1b2668e 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py 93f3dd1 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py 636f882 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/package/scripts/params.py 21a39d9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 804a654 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 3c02248 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 1955a3c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 0422a7c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py bc1494f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 7ed4322 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 8754930 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 463dccc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 636f882 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py 7de3367 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 75aa75c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py fb8e51a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 3c02248 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 88499ba 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0cf89be 

Diff: https://reviews.apache.org/r/18018/diff/


Testing
-------


Thanks,

Andrew Onischuk