You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Emil Anca <ea...@hortonworks.com> on 2015/06/12 16:50:36 UTC

Review Request 35392: Enable kerberos, add service prompts to change Hive configs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35392/
-----------------------------------------------------------

Review request for Ambari, Robert Levas and Srimanth Gunturi.


Bugs: AMBARI-11888
    https://issues.apache.org/jira/browse/AMBARI-11888


Repository: ambari


Description
-------

1) Install hdp 2.3 cluster with hive, etc, enable kerb
2) go to add service, add oozie (or anything other service...this happens regardless)
3) you are prompted to change 10 configs in hive
If I proceed, looks like end result wipes out some Hive configs, which will break kerb


*Problem*

During the initial recommendations request that sends no configs specific data, the hive_server2_auth flag will always be null and the Hive props related to kerberos will be uncorrectly wiped.

*Solution*
Since the flag above cannot be relied on, an additional check was made to see if Kerberos is part of the cluster.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 9390dfd 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 3c9844a 

Diff: https://reviews.apache.org/r/35392/diff/


Testing
-------

mvn clean test -pl ambari-server
Install HDP 2.3 Hive Cluster, add service, verify recommendations
Create new HDP 2.3 Cluster, select hive, verify recommendations


Thanks,

Emil Anca


Re: Review Request 35392: Enable kerberos, add service prompts to change Hive configs

Posted by Emil Anca <ea...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35392/
-----------------------------------------------------------

(Updated June 15, 2015, 2:22 p.m.)


Review request for Ambari, Robert Levas and Srimanth Gunturi.


Changes
-------

Patch went stale.


Bugs: AMBARI-11888
    https://issues.apache.org/jira/browse/AMBARI-11888


Repository: ambari


Description
-------

1) Install hdp 2.3 cluster with hive, etc, enable kerb
2) go to add service, add oozie (or anything other service...this happens regardless)
3) you are prompted to change 10 configs in hive
If I proceed, looks like end result wipes out some Hive configs, which will break kerb


*Problem*

During the initial recommendations request that sends no configs specific data, the hive_server2_auth flag will always be null and the Hive props related to kerberos will be uncorrectly wiped.

*Solution*
Since the flag above cannot be relied on, an additional check was made to see if Kerberos is part of the cluster.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 2380f2e 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9e5a3c0 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 614644f 

Diff: https://reviews.apache.org/r/35392/diff/


Testing
-------

mvn clean test -pl ambari-server
Install HDP 2.3 Hive Cluster, add service, verify recommendations
Create new HDP 2.3 Cluster, select hive, verify recommendations


Thanks,

Emil Anca


Re: Review Request 35392: Enable kerberos, add service prompts to change Hive configs

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35392/#review87859
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On June 12, 2015, 10:50 a.m., Emil Anca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35392/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 10:50 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-11888
>     https://issues.apache.org/jira/browse/AMBARI-11888
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Install hdp 2.3 cluster with hive, etc, enable kerb
> 2) go to add service, add oozie (or anything other service...this happens regardless)
> 3) you are prompted to change 10 configs in hive
> If I proceed, looks like end result wipes out some Hive configs, which will break kerb
> 
> 
> *Problem*
> 
> During the initial recommendations request that sends no configs specific data, the hive_server2_auth flag will always be null and the Hive props related to kerberos will be uncorrectly wiped.
> 
> *Solution*
> Since the flag above cannot be relied on, an additional check was made to see if Kerberos is part of the cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 9390dfd 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 3c9844a 
> 
> Diff: https://reviews.apache.org/r/35392/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -pl ambari-server
> Install HDP 2.3 Hive Cluster, add service, verify recommendations
> Create new HDP 2.3 Cluster, select hive, verify recommendations
> 
> 
> Thanks,
> 
> Emil Anca
> 
>