You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:46:00 UTC
Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d
src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
Diff: https://reviews.apache.org/r/57696/diff/1/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/#review169279
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 16, 2017, 5:22 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57696/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 5:22 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
> include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
> src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
> src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d
> src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
> src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
>
>
> Diff: https://reviews.apache.org/r/57696/diff/2/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/
-----------------------------------------------------------
(Updated March 23, 2017, 12:10 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Changes
-------
Rebased. NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
src/launcher/default_executor.cpp 6a885af50db6d489194cc9b780fcf1494e853694
src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
Diff: https://reviews.apache.org/r/57696/diff/5/
Changes: https://reviews.apache.org/r/57696/diff/4-5/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/#review169574
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On March 21, 2017, 3:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57696/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 3:34 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
> include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
> src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
> src/launcher/default_executor.cpp 6a885af50db6d489194cc9b780fcf1494e853694
> src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
> src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
>
>
> Diff: https://reviews.apache.org/r/57696/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/
-----------------------------------------------------------
(Updated March 21, 2017, 3:34 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Changes
-------
Gast�n's comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
src/launcher/default_executor.cpp 6a885af50db6d489194cc9b780fcf1494e853694
src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
Diff: https://reviews.apache.org/r/57696/diff/4/
Changes: https://reviews.apache.org/r/57696/diff/3-4/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/#review169464
-----------------------------------------------------------
Fix it, then Ship it!
src/common/type_utils.cpp
Lines 478 (patched)
<https://reviews.apache.org/r/57696/#comment241816>
I'd remove the commas after the check types.
- Gast�n Kleiman
On March 20, 2017, 11:56 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57696/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 11:56 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
> include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
> src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
> src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d
> src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
> src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
>
>
> Diff: https://reviews.apache.org/r/57696/diff/3/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/
-----------------------------------------------------------
(Updated March 20, 2017, 11:56 a.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d
src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
Diff: https://reviews.apache.org/r/57696/diff/3/
Changes: https://reviews.apache.org/r/57696/diff/2-3/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/#review169274
-----------------------------------------------------------
src/common/type_utils.cpp
Lines 490 (patched)
<https://reviews.apache.org/r/57696/#comment241624>
hmm. sending this unless an exit code or status code is available seems wrong? isn't empty checkstatus something you deliberately send for example?
src/v1/mesos.cpp
Lines 412 (patched)
<https://reviews.apache.org/r/57696/#comment241625>
ditto.
- Vinod Kone
On March 16, 2017, 5:22 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57696/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 5:22 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
> include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
> src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
> src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d
> src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
> src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
>
>
> Diff: https://reviews.apache.org/r/57696/diff/2/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57696/
-----------------------------------------------------------
(Updated March 16, 2017, 5:22 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a
include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6
src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7
src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d
src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46
src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce
Diff: https://reviews.apache.org/r/57696/diff/2/
Changes: https://reviews.apache.org/r/57696/diff/1-2/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov