You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/06 14:47:58 UTC
[GitHub] ashb commented on a change in pull request #4655: [AIRFLOW-XXX]
Improve linking to classes
ashb commented on a change in pull request #4655: [AIRFLOW-XXX] Improve linking to classes
URL: https://github.com/apache/airflow/pull/4655#discussion_r254299864
##########
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##########
@@ -196,7 +194,7 @@ def get_database(self, instance_id, database_id, project_id=None):
database. If set to None or missing, the default project_id from the GCP connection is used.
:type project_id: str
:return: Database object or None if database does not exist
- :rtype: Union[Database, None]
+ :rtype: Union[google.cloud.spanner_v1.database.Database, None]
Review comment:
```suggestion
:rtype: google.cloud.spanner_v1.database.Database or None
```
I think is the correct way of doing this in sphinx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services