You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/01/14 14:43:44 UTC

[GitHub] [couchdb-nano] glynnbird opened a new pull request #253: log before adding agents - fixes issue #252

glynnbird opened a new pull request #253:
URL: https://github.com/apache/couchdb-nano/pull/253


   ## Overview
   
   Fixes auth scrubbing bug where JSON.stringify on the `req` object could produce circular references when an HTTP Agent was used.
   
   Solution: log before adding the agent.
   
   ## Testing recommendations
   
   npm run test
   
   ## GitHub issue number
   
   Fixes issue #252 
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #253: log before adding agents - fixes issue #252

Posted by GitBox <gi...@apache.org>.

glynnbird merged pull request #253:
URL: https://github.com/apache/couchdb-nano/pull/253


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org