You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2015/04/26 19:38:33 UTC
Re: Review Request 30196: Patch for KAFKA-1886


> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote:
> > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295
> > <https://reviews.apache.org/r/30196/diff/2/?file=844610#file844610line295>
> >
> >     Why do you need the sleep here? We try to avoid blindly sleeping in Kafka tests since it almost always leads to transient test failures. Consider using TestUtils.waitUntilTrue().
> 
> Aditya Auradkar wrote:
>     Thanks Neha. I missed this review comment.
>     
>     I agree sleeping isn't ideal here but I don't think there is a condition I can wait on to trigger this specific exception. The client has to be waiting on a response from the server. I'm not even sure that this testcase needs to exist in PrimitiveApiTest since it isn't testing an API. Can you suggest a better place to put it, if it makes sense to keep it at all?

Yeah, if we can't make a fullproof unit test, let's remove it. We are really trying to reduce the number of randomly failing unit tests.


- Neha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30196/#review71556
-----------------------------------------------------------


On Feb. 2, 2015, 9:57 p.m., Aditya Auradkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30196/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 9:57 p.m.)
> 
> 
> Review request for kafka and Joel Koshy.
> 
> 
> Bugs: KAFKA-1886
>     https://issues.apache.org/jira/browse/KAFKA-1886
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Fixing KAFKA-1886. SimpleConsumer should not swallow ClosedByInterruptException
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala cbef84ac76e62768981f74e71d451f2bda995275 
>   core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala aeb7a19acaefabcc161c2ee6144a56d9a8999a81 
> 
> Diff: https://reviews.apache.org/r/30196/diff/
> 
> 
> Testing
> -------
> 
> Added an integration test to PrimitiveAPITest.scala.
> 
> 
> Thanks,
> 
> Aditya Auradkar
> 
>