You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/11 00:01:03 UTC

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module

junrushao1994 commented on a change in pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module
URL: https://github.com/apache/incubator-tvm/pull/4289#discussion_r344524435
 
 

 ##########
 File path: include/tvm/runtime/module.h
 ##########
 @@ -71,7 +70,11 @@ class Module {
    * \note Cyclic dependency is not allowed among modules,
    *  An error will be thrown when cyclic dependency is detected.
    */
-  TVM_DLL void Import(Module other);
 
 Review comment:
   Do we intentionally remove the TVM_DLL here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services