[GitHub] [accumulo] AlbertWhitlock commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade

[GitBox <gi...@apache.org>]

AlbertWhitlock commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r959890631


##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/tables.ftl:
##########
@@ -87,9 +87,14 @@
           tableList.ajax.reload(null, false ); // user paging is not reset on reload
         }
       </script>
+      <div class="row">
+         <div class="col-xs-12">
+            <h3>Table Overview</h3>
+         </div>
+      </div>
       <div>
-        <table id="tableList" class="table table-bordered table-striped table-condensed">
-          <caption><span class="table-caption">${tablesTitle}</span><br />

Review Comment:
   I put captions on each table and sometimes the 'title' of the page (that was at the top of the page) worked as well for a table caption so I added a different, hardcoded value for the page's overall title. I put the field substitution values back for the pages' titles and just changed the individual tables' captions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org