You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/06 02:46:09 UTC

[GitHub] [kafka] ableegoldman opened a new pull request #10484: MINOR: un-deprecate StreamsConfig overloads to support dependency injection

ableegoldman opened a new pull request #10484:
URL: https://github.com/apache/kafka/pull/10484


   In [#5344](https://github.com/apache/kafka/pull/5344#issuecomment-413350338) it came to our attention that the StreamsConfig overloads of the KafkaStreams constructors are actually quite useful for dependency injection, providing a cleaner way to configure dependencies and better type safety. 
   
   We considered removing these deprecated overloads in the upcoming 3.0 release, but decided against it for the above reasons. Since we no longer intend to remove these APIs it makes sense to drop the Deprecation entirely, so users can start or continue to use them without worry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman merged pull request #10484: MINOR: un-deprecate StreamsConfig overloads to support dependency injection

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10484:
URL: https://github.com/apache/kafka/pull/10484


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10484: MINOR: un-deprecate StreamsConfig overloads to support dependency injection

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10484:
URL: https://github.com/apache/kafka/pull/10484#issuecomment-815431683


   One unrelated flaky test failure: `kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org