You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by ppadma <gi...@git.apache.org> on 2017/10/05 05:20:55 UTC

[GitHub] drill pull request #974: DRILL-5839: Handle Empty Batches in Merge Receiver

GitHub user ppadma opened a pull request:

    https://github.com/apache/drill/pull/974

    DRILL-5839: Handle Empty Batches in Merge Receiver

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppadma/drill DRILL-5839

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #974
    
----
commit ae259534d5ebabfe7f64e170012bea96fd655943
Author: Padma Penumarthy <pp...@yahoo.com>
Date:   2017-10-01T00:33:17Z

    DRILL-5839: Handle Empty Batches in Merge Receiver

----


---

[GitHub] drill issue #974: DRILL-5839: Handle Empty Batches in Merge Receiver

Posted by ppadma <gi...@git.apache.org>.

Github user ppadma commented on the issue:

    https://github.com/apache/drill/pull/974
  
    @paul-rogers Thank you Paul. I made the change and pushed the new diffs. 


---

[GitHub] drill pull request #974: DRILL-5839: Handle Empty Batches in Merge Receiver

Posted by paul-rogers <gi...@git.apache.org>.

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/974#discussion_r143049947
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockRecordReader.java ---
    @@ -52,7 +52,7 @@ public MockRecordReader(FragmentContext context, MockScanEntry config) {
     
       private int getEstimatedRecordSize(MockColumn[] types) {
         int x = 0;
    -    for (int i = 0; i < types.length; i++) {
    +    for (int i = 0; i < (types == null ? 0 : types.length); i++) {
    --- End diff --
    
    Nit: maybe use:
    
    ```
    if (types == null) { return 0; }
    // Original code here..
    ```


---

[GitHub] drill pull request #974: DRILL-5839: Handle Empty Batches in Merge Receiver

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/974


---