You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2022/09/14 18:50:37 UTC
Re: Review Request 74120: RANGER-3911: NPE fix in RangerDefaultPolicyEvaluator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74120/#review224669
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Sept. 14, 2022, 2:06 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74120/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2022, 2:06 p.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3911
> https://issues.apache.org/jira/browse/RANGER-3911
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement:**
>
> ERROR org.apache.ranger.biz.RangerPolicyAdminCache: getPolicyAdmin(my_hive): failed to get latest policies from service-store
> java.lang.NullPointerException
> at org.apache.ranger.plugin.policyevaluator.RangerDefaultPolicyEvaluator.getAccess(RangerDefaultPolicyEvaluator.java:1094)
> at org.apache.ranger.plugin.policyevaluator.RangerDefaultPolicyEvaluator.preprocessPolicyItems(RangerDefaultPolicyEvaluator.java:1047)
> at org.apache.ranger.plugin.policyevaluator.RangerDefaultPolicyEvaluator.preprocessPolicy(RangerDefaultPolicyEvaluator.java:1020)
> at org.apache.ranger.plugin.policyevaluator.RangerDefaultPolicyEvaluator.init(RangerDefaultPolicyEvaluator.java:128)
> at org.apache.ranger.plugin.policyevaluator.RangerOptimizedPolicyEvaluator.init(RangerOptimizedPolicyEvaluator.java:74)
> at org.apache.ranger.plugin.policyengine.RangerPolicyRepository.buildPolicyEvaluator(RangerPolicyRepository.java:1108)
> at org.apache.ranger.plugin.policyengine.RangerPolicyRepository.init(RangerPolicyRepository.java:936)
> at org.apache.ranger.plugin.policyengine.RangerPolicyRepository.<init>(RangerPolicyRepository.java:229)
> at org.apache.ranger.plugin.policyengine.RangerPolicyRepository.<init>(RangerPolicyRepository.java:180)
> at org.apache.ranger.plugin.policyengine.PolicyEngine.<init>(PolicyEngine.java:212)
> at org.apache.ranger.biz.RangerPolicyAdminImpl.<init>(RangerPolicyAdminImpl.java:101)
> at org.apache.ranger.biz.RangerPolicyAdminCache.addPolicyAdmin(RangerPolicyAdminCache.java:195)
> at org.apache.ranger.biz.RangerPolicyAdminCache.addOrUpdatePolicyAdmin(RangerPolicyAdminCache.java:162)
> at org.apache.ranger.biz.RangerPolicyAdminCache.getServicePoliciesAdmin(RangerPolicyAdminCache.java:102)
> at org.apache.ranger.biz.RangerPolicyAdminCacheForEngineOptions.getServicePoliciesAdmin(RangerPolicyAdminCacheForEngineOptions.java:73)
> at org.apache.ranger.biz.RangerPolicyAdminCacheForEngineOptions.getServicePoliciesAdmin(RangerPolicyAdminCacheForEngineOptions.java:54)
> at org.apache.ranger.rest.ServiceREST.getPolicyAdminForDelegatedAdmin(ServiceREST.java:3592)
> at org.apache.ranger.rest.ServiceREST.applyAdminAccessFilter(ServiceREST.java:3465)
> at org.apache.ranger.rest.ServiceREST.getPolicies(ServiceREST.java:1938)
> at org.apache.ranger.rest.ServiceREST$$FastClassBySpringCGLIB$$92dab672.invoke(<generated>)
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
>
> ** Proposed Solution: **
> Addding Null check before accessing the method of RangerPolicyItemAccess object.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 51c28e3f3
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 235e84477
>
>
> Diff: https://reviews.apache.org/r/74120/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pradeep Agrawal
>
>