You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/18 17:34:08 UTC

[GitHub] [superset] eschutho commented on a change in pull request #16330: fix: Fix parsing onSaving reports toast when user hasn't saved chart

eschutho commented on a change in pull request #16330:
URL: https://github.com/apache/superset/pull/16330#discussion_r691466185



##########
File path: superset/reports/commands/base.py
##########
@@ -60,4 +61,4 @@ def validate_chart_dashboard(
                 exceptions.append(DashboardNotFoundValidationError())
             self._properties["dashboard"] = dashboard
         elif not update:
-            exceptions.append(ReportScheduleChartOrDashboardValidationError())
+            exceptions.append(ChartNotSavedValidationError())

Review comment:
       is it possible that this could be a dashboard?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org