You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by Dennis Federico <de...@gmail.com> on 2013/11/14 18:05:06 UTC

Review Request 15520: MRUNIT-13 Add support for MultipleOutputs (Based on the multipleOutputmock of Jiang Han)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15520/
-----------------------------------------------------------

Review request for mrunit.


Repository: mrunit


Description
-------

MRUNIT-13 Add support for MultipleOutputs
changes made from commit "trunk (8c3ca4869d9e9edb1e624803a5b2f8539f425dab)"


Diffs
-----

  pom.xml 4fdfb7d 
  src/main/java/org/apache/hadoop/mrunit/TestDriver.java 487c17f 
  src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java PRE-CREATION 
  src/main/java/org/apache/hadoop/mrunit/mapreduce/MapDriver.java 8f7b0a8 
  src/main/java/org/apache/hadoop/mrunit/mapreduce/ReduceDriver.java b36ce4a 
  src/test/java/org/apache/hadoop/mrunit/mapreduce/TestMultipleOutput.java PRE-CREATION 

Diff: https://reviews.apache.org/r/15520/diff/


Testing
-------


Thanks,

Dennis Federico


Re: Review Request 15520: MRUNIT-13 Add support for MultipleOutputs (Based on the multipleOutputmock of Jiang Han)

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15520/#review30748
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Dec. 19, 2013, 11:24 a.m., Dennis Federico wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15520/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 11:24 a.m.)
> 
> 
> Review request for mrunit.
> 
> 
> Repository: mrunit
> 
> 
> Description
> -------
> 
> MRUNIT-13 Add support for MultipleOutputs
> changes made from commit "trunk (8c3ca4869d9e9edb1e624803a5b2f8539f425dab)"
> 
> 
> Diffs
> -----
> 
>   pom.xml 4fdfb7d 
>   src/main/java/org/apache/hadoop/mrunit/TestDriver.java 487c17f 
>   src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java PRE-CREATION 
>   src/main/java/org/apache/hadoop/mrunit/mapreduce/MapDriver.java 8f7b0a8 
>   src/main/java/org/apache/hadoop/mrunit/mapreduce/ReduceDriver.java b36ce4a 
>   src/test/java/org/apache/hadoop/mrunit/mapreduce/TestMultipleOutput.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis Federico
> 
>


Re: Review Request 15520: MRUNIT-13 Add support for MultipleOutputs (Based on the multipleOutputmock of Jiang Han)

Posted by Dennis Federico <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15520/
-----------------------------------------------------------

(Updated Dec. 19, 2013, 11:24 a.m.)


Review request for mrunit.


Changes
-------

Fixes suggested by Brock Noland regarding tab expansion (indent size) and trailing whitespaces.
Note: Only applied to the new files and exiting files that I've modified somehow. It might have removed trailing whitespaces from the original code, I understand that's not a problem


Repository: mrunit


Description
-------

MRUNIT-13 Add support for MultipleOutputs
changes made from commit "trunk (8c3ca4869d9e9edb1e624803a5b2f8539f425dab)"


Diffs (updated)
-----

  pom.xml 4fdfb7d 
  src/main/java/org/apache/hadoop/mrunit/TestDriver.java 487c17f 
  src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java PRE-CREATION 
  src/main/java/org/apache/hadoop/mrunit/mapreduce/MapDriver.java 8f7b0a8 
  src/main/java/org/apache/hadoop/mrunit/mapreduce/ReduceDriver.java b36ce4a 
  src/test/java/org/apache/hadoop/mrunit/mapreduce/TestMultipleOutput.java PRE-CREATION 

Diff: https://reviews.apache.org/r/15520/diff/


Testing
-------


Thanks,

Dennis Federico


Re: Review Request 15520: MRUNIT-13 Add support for MultipleOutputs (Based on the multipleOutputmock of Jiang Han)

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15520/#review30563
-----------------------------------------------------------


Hi!

The patch looks good and I'd like to commit it!  Can you trim the trailing whitespace (shows up in red) and make sure the new files have two spaces per tab as opposed to 4?


src/main/java/org/apache/hadoop/mrunit/TestDriver.java
<https://reviews.apache.org/r/15520/#comment58526>

    Can you remove the whitespace issues? They show up in red.



src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java
<https://reviews.apache.org/r/15520/#comment58528>

    I think this file has 4 spaces? It should have 2.



src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java
<https://reviews.apache.org/r/15520/#comment58527>

    If this is not needed can we remove it?


- Brock Noland


On Nov. 14, 2013, 5:05 p.m., Dennis Federico wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15520/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 5:05 p.m.)
> 
> 
> Review request for mrunit.
> 
> 
> Repository: mrunit
> 
> 
> Description
> -------
> 
> MRUNIT-13 Add support for MultipleOutputs
> changes made from commit "trunk (8c3ca4869d9e9edb1e624803a5b2f8539f425dab)"
> 
> 
> Diffs
> -----
> 
>   pom.xml 4fdfb7d 
>   src/main/java/org/apache/hadoop/mrunit/TestDriver.java 487c17f 
>   src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java PRE-CREATION 
>   src/main/java/org/apache/hadoop/mrunit/mapreduce/MapDriver.java 8f7b0a8 
>   src/main/java/org/apache/hadoop/mrunit/mapreduce/ReduceDriver.java b36ce4a 
>   src/test/java/org/apache/hadoop/mrunit/mapreduce/TestMultipleOutput.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis Federico
> 
>