You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by gss2002 <gi...@git.apache.org> on 2018/03/08 01:44:48 UTC

[GitHub] zeppelin pull request #2849: ZEPPELIN-3309. Import/Clone doesn't set user in...

GitHub user gss2002 opened a pull request:

    https://github.com/apache/zeppelin/pull/2849

    ZEPPELIN-3309. Import/Clone doesn't set user in Paragraph causing NPE

    ### What is this PR for?
    During Import/Clone Paragraph set "user" to eliminate NPEs thrown in Helium and other functions leaving unusable notebooks.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3309
    
    ### How should this be tested?
    * Manually tested using Import/Clone of Notebooks and attempt to adjust bound interpreters
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Greg Senia <gs...@apache.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gss2002/zeppelin ZEPPELIN-3309

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2849
    
----
commit e4f01773e1f848d45d3706ad81a1f9801d256802
Author: gss2002 <gr...@...>
Date:   2018-03-08T01:39:19Z

    ZEPPELIN-3309. Import/Clone doesn't set user in Paragraph causing NPE

----


---

[GitHub] zeppelin issue #2849: ZEPPELIN-3309. Import/Clone doesn't set user in Paragr...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2849
  
    @gss2002 Thanks for contribution, could you add unit test for this to avoid regression in future ?


---

[GitHub] zeppelin issue #2849: ZEPPELIN-3309. Import/Clone doesn't set user in Paragr...

Posted by gss2002 <gi...@git.apache.org>.

Github user gss2002 commented on the issue:

    https://github.com/apache/zeppelin/pull/2849
  
    Closing this pull request for now will re-open with a new one which includes formatting changes and corrections and test cases.


---

[GitHub] zeppelin pull request #2849: ZEPPELIN-3309. Import/Clone doesn't set user in...

Posted by gss2002 <gi...@git.apache.org>.

Github user gss2002 closed the pull request at:

    https://github.com/apache/zeppelin/pull/2849


---

[GitHub] zeppelin issue #2849: ZEPPELIN-3309. Import/Clone doesn't set user in Paragr...

Posted by gss2002 <gi...@git.apache.org>.

Github user gss2002 commented on the issue:

    https://github.com/apache/zeppelin/pull/2849
  
    @zjffdu no problem. yes I will work on a unit test later tonight/tomorrow am.


---