[GitHub] [calcite] amaliujia commented on a change in pull request #1594: [CALCITE-3514] LatticeTest fails when JdbcSchema re-computes JdbcTables

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #1594: [CALCITE-3514] LatticeTest fails when JdbcSchema re-computes JdbcTables
URL: https://github.com/apache/calcite/pull/1594#discussion_r347549911
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcTable.java
 ##########
 @@ -200,6 +200,24 @@ public RelNode toRel(RelOptTable.ToRelContext context,
         sourceExpressionList, flattened);
   }
 
+  @Override public boolean equals(Object obj) {
 
 Review comment:
   even though this is trying to fix CALCITE-3514, because this is a general purpose `equals` implementation, it should checks equality of all fields of this class. Same for hashcode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services