You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "onichols-pivotal (GitHub)" <gi...@apache.org> on 2019/09/23 16:40:31 UTC

[GitHub] [geode] onichols-pivotal commented on issue #4078: GEODE-7226: Ignore @Immutable classes in PMD

A class-level @Immutable annotation would be useful iff PMD could leverage it to enforce that all fields are immutable or effectively immutable or annotated @Immutable. 

As it is, this PR seems to be proposing to de-automate a check currently performed by PMD, instead expecting "reviewers from the community should point them out while analysing the PR."  This seems like a step backwards.  Why is it such a bad thing that fields be analyzed and annotated individually?

[ Full content available at: https://github.com/apache/geode/pull/4078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org