[jira] [Commented] (HIVE-2881) Remove redundant key comparing in SMBMapJoinOperator

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243986#comment-13243986 ] 

Phabricator commented on HIVE-2881:
-----------------------------------

njain has accepted the revision "HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator".

  Looks good -

  I know this did not have good comments to start with, but it would be great if you can
  add more comments for changes like this. It took me a very long time to go over the
  code and make sure we are not missing any boundary condition. An example would
  have really helped.

REVISION DETAIL
  https://reviews.facebook.net/D2379

BRANCH
  DPAL-988

                
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
>                 Key: HIVE-2881
>                 URL: https://issues.apache.org/jira/browse/HIVE-2881
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira