[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r215371723
  
    --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java ---
    @@ -0,0 +1,50 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark;
    +
    +import org.apache.spark.annotation.DeveloperApi;
    +
    +/**
    + * A plugin which can be automaticaly instantiated within each Spark executor.  Users can specify
    + * plugins which should be created with the "spark.executor.plugins" configuration.  An instance
    + * of each plugin will be created for every executor, including those created by dynamic allocation,
    + * before the executor starts running any tasks.
    + *
    + * The specific api exposed to the end users still considered to be very unstable.  We will
    + * hopefully be able to keep compatability by providing default implementations for any methods
    + * added, but make no guarantees this will always be possible across all Spark releases.
    + *
    + * Spark does nothing to verify the plugin is doing legitimate things, or to manage the resources
    + * it uses.  A plugin acquires the same privileges as the user running the task.  A bad plugin
    + * could also intefere with task execution and make the executor fail in unexpected ways.
    + */
    +@DeveloperApi
    +public interface ExecutorPlugin {
    +
    +  /**
    +   * Initialization method that will be called during executor startup, in the same thread as
    +   * the executor. Plugins should override this method to add in their initialization logic.
    +   */
    +  default void init() {}
    --- End diff --
    
    I think it should be either `init` & `shutdown`, or `start` & `stop`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org