You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "gaoxiaolei-s59 (via GitHub)" <gi...@apache.org> on 2026/07/21 07:06:36 UTC
[PR] [ISSUE #16389] Close late input after streaming decoder shutdown [dubbo]
gaoxiaolei-s59 opened a new pull request, #16391:
URL: https://github.com/apache/dubbo/pull/16391
## What is the purpose of the change
Fixes #16389. Triple HTTP/2 wraps DATA frames in an auto-closing input stream. When a DATA frame arrives after the streaming decoder starts closing or has closed, the decoder previously returned without closing that stream, leaving the underlying ByteBuf unreleased.
## Brief changelog
- Close input streams rejected while the decoder is closing or closed.
- Propagate input close failures as DecodeException.
- Add regression coverage for both closing and closed decoder states.
## Verifying this change
- LengthFieldStreamingDecoderTest: 2 tests passed.
- All dubbo-remoting-http12 tests: 23 tests passed, 2 skipped.
- Spotless and reactor compilation checks passed.
The broader dependency-reactor test run reached 1,165 dubbo-common tests and was stopped by the pre-existing environment-sensitive NetUtilsTest.testMatchIpRangeMatchWhenIpWrongException failure; the target module had not started in that run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [ISSUE #16389] Close late input after streaming decoder shutdown [dubbo]
Posted by "EarthChen (via GitHub)" <gi...@apache.org>.
EarthChen merged PR #16391:
URL: https://github.com/apache/dubbo/pull/16391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [ISSUE #16389] Close late input after streaming decoder shutdown [dubbo]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16391:
URL: https://github.com/apache/dubbo/pull/16391#issuecomment-5031359681
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/16391?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.66%. Comparing base ([`d0bf5c3`](https://app.codecov.io/gh/apache/dubbo/commit/d0bf5c36d092da8067b15a1d1d00884a8c399e8e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`973e64c`](https://app.codecov.io/gh/apache/dubbo/commit/973e64cccb876ee8021a6252b1d2bee6bf9aaca5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo/pull/16391?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ng/http12/message/LengthFieldStreamingDecoder.java](https://app.codecov.io/gh/apache/dubbo/pull/16391?src=pr&el=tree&filepath=dubbo-remoting%2Fdubbo-remoting-http12%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Fremoting%2Fhttp12%2Fmessage%2FLengthFieldStreamingDecoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctaHR0cDEyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9odHRwMTIvbWVzc2FnZS9MZW5ndGhGaWVsZFN0cmVhbWluZ0RlY29kZXIuamF2YQ==) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo/pull/16391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.3 #16391 +/- ##
============================================
- Coverage 60.86% 60.66% -0.21%
+ Complexity 11763 15 -11748
============================================
Files 1953 1953
Lines 89262 89250 -12
Branches 13471 13387 -84
============================================
- Hits 54331 54141 -190
- Misses 29329 29480 +151
- Partials 5602 5629 +27
```
| [Flag](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.14% <0.00%> (+0.04%)` | :arrow_up: |
| [integration-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.25% <0.00%> (+0.09%)` | :arrow_up: |
| [samples-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.16% <0.00%> (+0.01%)` | :arrow_up: |
| [samples-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.70% <0.00%> (-0.10%)` | :arrow_down: |
| [unit-tests-java11](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java17](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java25](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.51% <50.00%> (-0.03%)` | :arrow_down: |
| [unit-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/16391/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo/pull/16391?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org