You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/06/15 13:06:09 UTC
Review Request 35453: LENS-604: Add "time dimension not supported" as
a fact prune cause
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35453/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-604
https://issues.apache.org/jira/browse/LENS-604
Repository: lens
Description
-------
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 049826a252e21b07f3c967f8658d9d3aeec8b5dc
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f1ad6ef3b8f6a772b2724d0e4c55805d32f33cc
Diff: https://reviews.apache.org/r/35453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 35453: LENS-604: Add "time dimension not
supported" as a fact prune cause
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35453/#review88028
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java (line 57)
<https://reviews.apache.org/r/35453/#comment140435>
Should it be moved down? just before NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE ?
- Amareshwari Sriramadasu
On June 15, 2015, 11:06 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35453/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 11:06 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-604
> https://issues.apache.org/jira/browse/LENS-604
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 049826a252e21b07f3c967f8658d9d3aeec8b5dc
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f1ad6ef3b8f6a772b2724d0e4c55805d32f33cc
>
> Diff: https://reviews.apache.org/r/35453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 35453: LENS-604: Add "time dimension not
supported" as a fact prune cause
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35453/#review88356
-----------------------------------------------------------
Ship it!
Make sure you tested error messages on cli are fine.
- Amareshwari Sriramadasu
On June 16, 2015, 6:30 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35453/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 6:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-604
> https://issues.apache.org/jira/browse/LENS-604
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 049826a252e21b07f3c967f8658d9d3aeec8b5dc
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f1ad6ef3b8f6a772b2724d0e4c55805d32f33cc
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 4c2a7a4849d843914a4ff535b0de888ea20dee11
>
> Diff: https://reviews.apache.org/r/35453/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.734s]
> [INFO] Lens .............................................. SUCCESS [3.215s]
> [INFO] Lens API .......................................... SUCCESS [21.296s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.921s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.594s]
> [INFO] Lens DB storage ................................... SUCCESS [20.201s]
> [INFO] Lens Query Library ................................ SUCCESS [15.133s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.902s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.086s]
> [INFO] Lens Server ....................................... SUCCESS [5:30.661s]
> [INFO] Lens client ....................................... SUCCESS [36.037s]
> [INFO] Lens CLI .......................................... SUCCESS [3:34.074s]
> [INFO] Lens Examples ..................................... SUCCESS [9.021s]
> [INFO] Lens Distribution ................................. SUCCESS [8.416s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.784s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.827s]
> [INFO] Lens Regression ................................... SUCCESS [11.275s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:03.125s
> [INFO] Finished at: Tue Jun 16 06:15:21 UTC 2015
> [INFO] Final Memory: 170M/1320M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 35453: LENS-604: Add "time dimension not
supported" as a fact prune cause
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35453/
-----------------------------------------------------------
(Updated June 16, 2015, noon)
Review request for lens.
Bugs: LENS-604
https://issues.apache.org/jira/browse/LENS-604
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 049826a252e21b07f3c967f8658d9d3aeec8b5dc
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f1ad6ef3b8f6a772b2724d0e4c55805d32f33cc
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 4c2a7a4849d843914a4ff535b0de888ea20dee11
Diff: https://reviews.apache.org/r/35453/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.734s]
[INFO] Lens .............................................. SUCCESS [3.215s]
[INFO] Lens API .......................................... SUCCESS [21.296s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.921s]
[INFO] Lens Cube ......................................... SUCCESS [3:34.594s]
[INFO] Lens DB storage ................................... SUCCESS [20.201s]
[INFO] Lens Query Library ................................ SUCCESS [15.133s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.902s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.086s]
[INFO] Lens Server ....................................... SUCCESS [5:30.661s]
[INFO] Lens client ....................................... SUCCESS [36.037s]
[INFO] Lens CLI .......................................... SUCCESS [3:34.074s]
[INFO] Lens Examples ..................................... SUCCESS [9.021s]
[INFO] Lens Distribution ................................. SUCCESS [8.416s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.784s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.827s]
[INFO] Lens Regression ................................... SUCCESS [11.275s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:03.125s
[INFO] Finished at: Tue Jun 16 06:15:21 UTC 2015
[INFO] Final Memory: 170M/1320M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal