You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (JIRA)" <ji...@apache.org> on 2019/08/12 09:44:00 UTC
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore
backwards compatible
[ https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Till Rohrmann updated FLINK-13692:
----------------------------------
Description:
With FLINK-11159 we changed the signature of {{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which causes users of this interface to adapt their implementation and recompile it. Since {{CompletedCheckpointStore}} is no public API, this change is technically ok, but not so nice.
If we decide to provide backwards compatibility, then we should still keep {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least, we should update the JavaDocs of the {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the passed parameter states.
was:
With FLINK-11159 we changed the signature of {{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which causes users of this interface to adapt their implementation and recompile it. Since {{CompletedCheckpointStore}} is no public API, this change is technically ok, but not so nice.
If we decide to provide backwards compatibility, then we should still keep {{getLatestCheckpoint()}} and add a deprecation annotation to it. Otherwise we should close this issue.
> Make CompletedCheckpointStore backwards compatible
> --------------------------------------------------
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Affects Versions: 1.9.0, 1.10.0
> Reporter: Till Rohrmann
> Priority: Major
> Fix For: 1.10.0, 1.9.1
>
>
> With FLINK-11159 we changed the signature of {{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which causes users of this interface to adapt their implementation and recompile it. Since {{CompletedCheckpointStore}} is no public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least, we should update the JavaDocs of the {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the passed parameter states.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)