You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2023/04/17 08:28:37 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1447: fix: Fault-tolerant storage engine errors for read operations
acelyc111 opened a new pull request, #1447:
URL: https://github.com/apache/incubator-pegasus/pull/1447
https://github.com/apache/incubator-pegasus/issues/1383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1447: fix: Fault-tolerant storage engine errors for read operations
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1447:
URL: https://github.com/apache/incubator-pegasus/pull/1447#discussion_r1174557656
##########
src/runtime/serverlet.h:
##########
@@ -90,6 +90,8 @@ class rpc_replier
return _response != nullptr ? _response->to_address : rpc_address::s_invalid_address;
}
+ int error_code() const { return _response != nullptr ? _response->error() : 0; }
Review Comment:
For `rpc_replier`, the reason why we just need the error code in `message_ex`, rather than field `error` in thrift object `TResponse`, is that there is no read api (`on_get`, `on_multi_get`, ...) using `rpc_replier` to reply ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1447: fix: Fault-tolerant storage engine errors for read operations
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1447:
URL: https://github.com/apache/incubator-pegasus/pull/1447#discussion_r1174786959
##########
src/runtime/serverlet.h:
##########
@@ -90,6 +90,8 @@ class rpc_replier
return _response != nullptr ? _response->to_address : rpc_address::s_invalid_address;
}
+ int error_code() const { return _response != nullptr ? _response->error() : 0; }
Review Comment:
Only simple_kv use this register function, simple_kv is just a simple demo of rdsn framework, so I'll update the code to limit the usage of function
```
template <typename TReq, typename TResp>
static bool register_async_rpc_handler(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1447: fix: Fault-tolerant storage engine errors for read operations
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1447:
URL: https://github.com/apache/incubator-pegasus/pull/1447#discussion_r1174786959
##########
src/runtime/serverlet.h:
##########
@@ -90,6 +90,8 @@ class rpc_replier
return _response != nullptr ? _response->to_address : rpc_address::s_invalid_address;
}
+ int error_code() const { return _response != nullptr ? _response->error() : 0; }
Review Comment:
Only simple_kv use this register function, simple_kv is just a simple demo of rdsn framework, so I'll update the code to limit the usage of function:
```
template <typename TReq, typename TResp>
static bool register_async_rpc_handler(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1447: fix: Fault-tolerant storage engine errors for read operations
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1447:
URL: https://github.com/apache/incubator-pegasus/pull/1447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org